Paths

Table of Contentst

Differential D7777

[native] Add search button to chat header
ClosedPublic
Actions

Authored by inka on May 10 2023, 3:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 3, 8:52 PM

	Unknown Object (File)
	Sun, Dec 1, 11:39 AM

	Unknown Object (File)
	Fri, Nov 29, 7:30 AM

	Unknown Object (File)
	Fri, Nov 29, 7:05 AM

	Unknown Object (File)
	Fri, Nov 29, 6:15 AM

	Unknown Object (File)
	Wed, Nov 27, 10:05 PM

	Unknown Object (File)
	Nov 25 2024, 6:40 PM

	Unknown Object (File)
	Nov 25 2024, 4:23 PM

Subscribers

Details

Reviewers

• kuba
kamil
bartek

Commits

rCOMMa347177eb2b5: [native] Add search button to chat header

Summary

issue: https://linear.app/comm/issue/ENG-3404/add-magnifying-glass-button-to-message-list-header

Test Plan

Opened a chat, pressed on the button, checked that is navigates to the search screen

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 10 2023, 3:59 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 10 2023, 3:59 AM

inka added a parent revision: D7775: [native] Use MessageSearchContent.May 10 2023, 3:59 AM

Harbormaster completed remote builds in B19234: Diff 26334.May 10 2023, 4:17 AM

inka requested review of this revision.May 10 2023, 4:18 AM

• kuba added inline comments.May 11 2023, 2:39 AM

native/chat/chat.react.js
238 ↗	(On Diff #26334)	Is disabling lint here necessary?

Address review

native/chat/chat.react.js
240 ↗	(On Diff #26421)	@kuba is this better?

Harbormaster completed remote builds in B19307: Diff 26421.May 12 2023, 2:13 AM

ashoat added inline comments.May 13 2023, 11:57 AM

native/chat/chat.react.js
222 ↗	(On Diff #26421)	There is no reason to define a new version of this on every function invocation. Please move it outside of `messageListOptions`

Move headerRightStyle out

Harbormaster completed remote builds in B19374: Diff 26507.May 16 2023, 4:10 AM

kamil accepted this revision.May 17 2023, 3:43 AM

kamil added inline comments.

native/search/search-messages-button.react.js
22–28 ↗	(On Diff #26507)	shouldn't we wrap this in `React.useCallback`?

This revision is now accepted and ready to land.May 17 2023, 3:43 AM

Use useCallback

Harbormaster completed remote builds in B19539: Diff 26719.May 20 2023, 1:03 AM

inka added a child revision: D7935: Remove ListLoadingIndicator background color.May 23 2023, 2:52 AM

inka edited parent revisions, added: D7774: [native] Add MessageSearchContent; removed: D7775: [native] Use MessageSearchContent.May 23 2023, 8:09 AM

Closed by commit rCOMMa347177eb2b5: [native] Add search button to chat header (authored by • InkaSokolowska). · Explain WhyMay 24 2023, 2:12 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMMa347177eb2b5: [native] Add search button to chat header.

Revision Contents
Changeset List

Path

Size

native/

chat/

17 lines

search/

search-messages-button.react.js

44 lines

Diff 26938

native/chat/chat.react.js

Loading...

native/search/search-messages-button.react.js

Loading...