Page MenuHomePhabricator

[native] Add search button to chat header
ClosedPublic

Authored by inka on May 10 2023, 3:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 7:32 PM
Unknown Object (File)
Sat, Jun 15, 6:03 AM
Unknown Object (File)
Wed, Jun 12, 10:46 AM
Unknown Object (File)
Mon, Jun 10, 3:26 AM
Unknown Object (File)
Sun, Jun 9, 9:45 PM
Unknown Object (File)
Sun, Jun 9, 8:43 AM
Unknown Object (File)
Sat, Jun 8, 11:22 PM
Unknown Object (File)
Sat, Jun 8, 11:45 AM
Subscribers

Details

Summary
Test Plan

Opened a chat, pressed on the button, checked that is navigates to the search screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.May 10 2023, 4:18 AM
native/chat/chat.react.js
238 ↗(On Diff #26334)

Is disabling lint here necessary?

Address review

native/chat/chat.react.js
240 ↗(On Diff #26421)

@kuba is this better?

native/chat/chat.react.js
222 ↗(On Diff #26421)

There is no reason to define a new version of this on every function invocation. Please move it outside of messageListOptions

Move headerRightStyle out

kamil added inline comments.
native/search/search-messages-button.react.js
22–28 ↗(On Diff #26507)

shouldn't we wrap this in React.useCallback?

This revision is now accepted and ready to land.May 17 2023, 3:43 AM