The new item is displayed conditionally based on the permissions and uses an SVG icon.
Depends on D8306
Details
Details
Check if the new item is displayed for communities where user has permission.
Check if invite link button is displayed only when invite link exists.
Check if three dots button is displayed only when there's a menu item.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Shouldn't we return null when items is an empty array, as before?
We discussed this offline and the code doesn't need to be changed. The menu button will not render because Menu component makes sure of that, but the container will, which allows for all long community names to end in the same place (whether the button is present or not), as had been requested in the designs.
| web/invite-links/invite-links-menu.react.js | ||
|---|---|---|
| 51 ↗ | (On Diff #28054) | I guess we should be consistent with native and use Manage invite links |