Page MenuHomePhabricator
Differential D8417

[web] Call update or create invite link endpoint
ClosedPublic
Actions

Authored by tomek on Jul 3 2023, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 5:16 AM
Unknown Object (File)
Sat, May 4, 5:16 AM
Unknown Object (File)
Sat, May 4, 5:16 AM
Unknown Object (File)
Sat, May 4, 5:16 AM
Unknown Object (File)
Sat, May 4, 5:13 AM
Unknown Object (File)
Sat, May 4, 4:43 AM
Unknown Object (File)
Apr 3 2024, 9:48 AM
Unknown Object (File)
Apr 3 2024, 9:48 AM
View All 34 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
bartek
Commits
rCOMM1c1c441933e7: [web] Call update or create invite link endpoint
Summary

Update or create a new link when a button is clicked.

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=11400%3A288456&mode=dev

web-invalid-link.png (1×1 px, 122 KB)

Depends on D8416

Test Plan

Check if creating new links works. Then, check if it is possible to update it.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jul 3 2023, 6:33 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 3 2023, 6:33 AM
tomek added a child revision: D8419: [web] Introduce disable link modal.Jul 3 2023, 6:39 AM
Harbormaster completed remote builds in B20686: Diff 28348.Jul 3 2023, 6:49 AM
tomek requested review of this revision.Jul 3 2023, 6:49 AM
inka accepted this revision.Jul 4 2023, 12:50 AM
inka added inline comments.
web/invite-links/manage/edit-link-modal.react.js
36–40 ↗(On Diff #28348)

Would be nice to see some screenshots if we are adding GUI elements

This revision is now accepted and ready to land.Jul 4 2023, 12:50 AM
tomek edited the summary of this revision. (Show Details)Jul 5 2023, 4:21 AM
tomek added inline comments.
web/invite-links/manage/edit-link-modal.react.js
36–40 ↗(On Diff #28348)

You're right! Updated a summary with it.

tomek updated this revision to Diff 28409.Jul 5 2023, 4:23 AM

Rebase

Harbormaster completed remote builds in B20736: Diff 28409.Jul 5 2023, 4:40 AM
tomek updated this revision to Diff 28437.Jul 6 2023, 7:08 AM

Rebase

Harbormaster completed remote builds in B20761: Diff 28437.Jul 6 2023, 7:25 AM
Closed by commit rCOMM1c1c441933e7: [web] Call update or create invite link endpoint (authored by tomek). · Explain WhyJul 10 2023, 5:49 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1c1c441933e7: [web] Call update or create invite link endpoint.

Revision Contents
Changeset List

Diff 28541

View Options

web/invite-links/manage-invite-links-modal.react.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...
View Options

web/invite-links/manage/manage-invite-links-modal.css

Loading...