Page MenuHomePhabricator
Differential D8415

[web] Introduce edit link modal
ClosedPublic
Actions

Authored by tomek on Jul 3 2023, 5:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 5:06 PM
Unknown Object (File)
Mon, May 6, 10:15 AM
Unknown Object (File)
Sat, May 4, 11:52 AM
Unknown Object (File)
Sat, May 4, 5:15 AM
Unknown Object (File)
Sat, May 4, 5:15 AM
Unknown Object (File)
Sat, May 4, 5:15 AM
Unknown Object (File)
Sat, May 4, 5:15 AM
Unknown Object (File)
Sat, May 4, 5:15 AM
View All 56 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
bartek
ashoat
Commits
rCOMM5e19f016d6b8: [web] Introduce edit link modal
Summary

Introduce a stage of manage link modal where a link can be modified / created.

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=11341%3A281468&mode=dev

edit-modal.png (938×1 px, 104 KB)

Depends on D8414

Test Plan

Check if edit link and enable link buttons point to edit link modal. Check if the modal is displayed correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jul 3 2023, 5:12 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 3 2023, 5:12 AM
tomek edited the summary of this revision. (Show Details)Jul 3 2023, 5:12 AM
tomek added a reviewer: ashoat.
Harbormaster completed remote builds in B20683: Diff 28345.Jul 3 2023, 5:29 AM
tomek requested review of this revision.Jul 3 2023, 5:29 AM
tomek added a child revision: D8416: [lib] Extract invite links actions.Jul 3 2023, 6:28 AM
ashoat accepted this revision.Jul 3 2023, 11:05 AM
ashoat added inline comments.
web/invite-links/manage/edit-link-modal.react.js
38–44 ↗(On Diff #28345)

In ENG-4304, I shared replacement text for this screen on native. We can use the same text on web:

Invite links make it easy for your friends to join your community. Anybody who knows your community's invite link will be able to join it. Note that if you change your public link's URL, other communities will be able to claim the old URL.

This revision is now accepted and ready to land.Jul 3 2023, 11:05 AM
tomek updated this revision to Diff 28406.Jul 5 2023, 4:01 AM

Update copy

web/invite-links/manage/edit-link-modal.react.js
38–44 ↗(On Diff #28345)

web-edit-link-new-copy.png (952×1 px, 100 KB)

tomek attached a referenced file: F621583: web-edit-link-new-copy.png. (Show Details)Jul 5 2023, 4:01 AM
Harbormaster completed remote builds in B20733: Diff 28406.Jul 5 2023, 4:17 AM
tomek updated this revision to Diff 28436.Jul 6 2023, 7:04 AM

Rebase

Harbormaster completed remote builds in B20760: Diff 28436.Jul 6 2023, 7:20 AM
ashoat added inline comments.Jul 6 2023, 12:35 PM
web/invite-links/manage/edit-link-modal.react.js
41–42 ↗(On Diff #28436)

Let's avoid using <br /> for spacing

tomek updated this revision to Diff 28464.Jul 7 2023, 2:33 AM

Use 12px gap instead of new line chars

web/invite-links/manage/edit-link-modal.react.js
41–42 ↗(On Diff #28436)

Changed line breaks to 12px gap

web-edit-link-gap.png (976×1 px, 103 KB)

tomek attached a referenced file: F624807: web-edit-link-gap.png. (Show Details)Jul 7 2023, 2:33 AM
Harbormaster completed remote builds in B20784: Diff 28464.Jul 7 2023, 2:50 AM
Closed by commit rCOMM5e19f016d6b8: [web] Introduce edit link modal (authored by tomek). · Explain WhyJul 10 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM5e19f016d6b8: [web] Introduce edit link modal.

Revision Contents
Changeset List

Diff 28539

View Options

web/invite-links/manage-invite-links-modal.react.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...
View Options

web/invite-links/manage/empty-link-content.react.js

Loading...
View Options

web/invite-links/manage/existing-link-content.react.js

Loading...
View Options

web/invite-links/manage/manage-invite-links-modal.css

Loading...
View Options

web/modals/input.react.js

Loading...