Page MenuHomePhabricator
Differential D8236

[keyserver] Return invite links in initial web state
ClosedPublic
Actions

Authored by tomek on Jun 16 2023, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 5:59 PM
Unknown Object (File)
Thu, Mar 6, 5:07 PM
Unknown Object (File)
Thu, Mar 6, 5:07 PM
Unknown Object (File)
Thu, Mar 6, 5:07 PM
Unknown Object (File)
Thu, Mar 6, 5:00 PM
Unknown Object (File)
Feb 20 2025, 4:30 AM
Unknown Object (File)
Feb 20 2025, 4:22 AM
Unknown Object (File)
Feb 13 2025, 10:16 AM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
michal
Commits
rCOMM79342e60cd2b: [keyserver] Return invite links in initial web state
Summary

When we return initial redux state, we should include invite links which the viewer can use.

The stack contains the implementation of https://linear.app/comm/issue/ENG-3930/accessing-invite-links-non-admin-users-web.

Test Plan

Open web app and check if the links are included in initial redux state.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
19 lines
lib/
types/
9 lines

Diff 28104

View Options

keyserver/src/responders/website-responders.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines
View Options

lib/types/link-types.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines