Page MenuHomePhabricator
Differential D8236

[keyserver] Return invite links in initial web state
ClosedPublic
Actions

Authored by tomek on Jun 16 2023, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 10:45 PM
Unknown Object (File)
Mar 15 2025, 5:59 PM
Unknown Object (File)
Mar 6 2025, 5:07 PM
Unknown Object (File)
Mar 6 2025, 5:07 PM
Unknown Object (File)
Mar 6 2025, 5:07 PM
Unknown Object (File)
Mar 6 2025, 5:00 PM
Unknown Object (File)
Feb 20 2025, 4:30 AM
Unknown Object (File)
Feb 20 2025, 4:22 AM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
michal
Commits
rCOMM79342e60cd2b: [keyserver] Return invite links in initial web state
Summary

When we return initial redux state, we should include invite links which the viewer can use.

The stack contains the implementation of https://linear.app/comm/issue/ENG-3930/accessing-invite-links-non-admin-users-web.

Test Plan

Open web app and check if the links are included in initial redux state.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
19 lines
lib/
types/
9 lines

Diff 28104

View Options

keyserver/src/responders/website-responders.js

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines
View Options

lib/types/link-types.js

  • This file was copied from services/backup/src/Reactors/client/blob/BlobGetClientReactor.h.
#pragma once
#include "ClientReadReactorBase.h" #include "BlobGetClientReactor.h"
#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"
#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>
#include <memory>
#include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace reactor { namespace reactor {
class BlobGetClientReactor
: public ClientReadReactorBase<blob::GetRequest, blob::GetResponse> {
std::string holder;
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks;
public:
BlobGetClientReactor(
const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks);
std::unique_ptr<grpc::Status>
readResponse(blob::GetResponse &response) override;
void doneCallback() override;
grpc::Status getStatus() const;
};
BlobGetClientReactor::BlobGetClientReactor( BlobGetClientReactor::BlobGetClientReactor(
const std::string &holder, const std::string &holder,
std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks) std::shared_ptr<folly::MPMCQueue<std::string>> dataChunks)
: holder(holder), dataChunks(dataChunks) { : holder(holder), dataChunks(dataChunks) {
} }
std::unique_ptr<grpc::Status> std::unique_ptr<grpc::Status>
BlobGetClientReactor::readResponse(blob::GetResponse &response) { BlobGetClientReactor::readResponse(blob::GetResponse &response) {
Show All 17 Lines