Page MenuHomePhabricator
Differential D8306

[web] Allow other types of icons in menu item
ClosedPublic
Actions

Authored by tomek on Jun 23 2023, 8:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 7:46 PM
Unknown Object (File)
Tue, May 7, 9:45 AM
Unknown Object (File)
Tue, May 7, 9:45 AM
Unknown Object (File)
Tue, May 7, 9:45 AM
Unknown Object (File)
Sat, May 4, 5:14 AM
Unknown Object (File)
Sat, May 4, 5:13 AM
Unknown Object (File)
Sat, May 4, 5:12 AM
Unknown Object (File)
Sat, May 4, 4:43 AM
View All 46 Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
Commits
rCOMM3ea12fe1fe4c: [web] Allow other types of icons in menu item
Summary

Currently, we allow only SWMansionIcons and provide them through their name. A design for invite links requires an icon which isn't a part of this set. This diff allows using any other icon, especially any svg.

Depends on D8294

Test Plan

Check if the items are still displayed correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jun 23 2023, 8:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 23 2023, 8:51 AM
tomek added a child revision: D8307: [web] Add manage invite links menu item.Jun 23 2023, 8:52 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 9:12 AM
Harbormaster failed remote builds in B20471: Diff 28053!
Harbormaster completed remote builds in B20471: Diff 28053.Jun 26 2023, 4:13 AM
tomek requested review of this revision.Jun 26 2023, 4:13 AM
inka accepted this revision.Jun 26 2023, 6:06 AM

Why are the strokes necessary?

This revision is now accepted and ready to land.Jun 26 2023, 6:06 AM
tomek added a comment.Jun 26 2023, 7:57 AM
In D8306#245283, @inka wrote:

Why are the strokes necessary?

Some icons are SVGs and their color can be changed using stroke instead of color css property

Closed by commit rCOMM3ea12fe1fe4c: [web] Allow other types of icons in menu item (authored by tomek). · Explain WhyJul 10 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM3ea12fe1fe4c: [web] Allow other types of icons in menu item.
atul mentioned this in D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.Aug 2 2023, 12:50 AM

Revision Contents
Changeset List

PathSize
web/
components/
23 lines
6 lines

Diff 28534

View Options

web/components/menu-item.react.js

Loading...
View Options

web/components/menu.css

Loading...