Manage links modal is complicated so it makes sense to split it into multiple components. Following diffs will introduce new components that are conditionally displayed.
Depends on D8413
Paths
| Differential D8414 Authored by tomek on Jul 3 2023, 5:07 AM.
Details
Summary Manage links modal is complicated so it makes sense to split it into multiple components. Following diffs will introduce new components that are conditionally displayed. Depends on D8413 Test Plan This is only a refactoring. Tested if the modal still works.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptJul 3 2023, 5:07 AM2023-07-03 05:07:41 (UTC-7) tomek added a child revision: D8415: [web] Introduce edit link modal.Jul 3 2023, 5:12 AM2023-07-03 05:12:20 (UTC-7) Harbormaster completed remote builds in B20682: Diff 28344.Jul 3 2023, 5:25 AM2023-07-03 05:25:48 (UTC-7) This revision is now accepted and ready to land.Jul 4 2023, 12:23 AM2023-07-04 00:23:05 (UTC-7)
Harbormaster completed remote builds in B20759: Diff 28435.Jul 6 2023, 7:15 AM2023-07-06 07:15:48 (UTC-7) Closed by commit rCOMMb3529340de90: [web] Split modal into multiple components (authored by tomek). · Explain WhyJul 10 2023, 5:48 AM2023-07-10 05:48:59 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 28538 web/invite-links/manage-invite-links-modal.css
web/invite-links/manage-invite-links-modal.react.js
web/invite-links/manage/empty-link-content.react.js
web/invite-links/manage/existing-link-content.react.js
|