[native] Make manage links modal consistent with web
ClosedPublic
Actions

Authored by tomek on Jul 7 2023, 6:12 AM.

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMMaafdbef2ec76: [native] Make manage links modal consistent with web

Summary

The approach is described in https://phab.comm.dev/D8419#248576 comment.
In this diff we're:

Replacing new lines with margin
Moving disable button to a new section
Changing disable button copy
Introducing a description of disable action

Depends on D8423

Test Plan

Check if the screen looks like intended.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 7 2023, 6:12 AM

tomek edited the summary of this revision. (Show Details)Jul 7 2023, 6:13 AM

Harbormaster completed remote builds in B20798: Diff 28478.Jul 7 2023, 6:29 AM

tomek requested review of this revision.Jul 7 2023, 6:29 AM

ashoat accepted this revision.Jul 7 2023, 11:57 AM

This revision is now accepted and ready to land.Jul 7 2023, 11:57 AM

tomek mentioned this in D8419: [web] Introduce disable link modal.Jul 10 2023, 1:24 AM

tomek mentioned this in D8423: [web][native] Update invite link copy.Jul 10 2023, 1:28 AM

tomek added a child revision: D8461: [lib] Fix primary links reducer.Jul 10 2023, 3:42 AM

Closed by commit rCOMMaafdbef2ec76: [native] Make manage links modal consistent with web (authored by tomek). · Explain WhyJul 10 2023, 5:49 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMaafdbef2ec76: [native] Make manage links modal consistent with web.

Revision Contents
Changeset List

Path

Size

native/

invite-links/

manage-public-link-screen.react.js

33 lines

Diff 28544

View Options

native/invite-links/manage-public-link-screen.react.js

[native] Make manage links modal consistent with webClosedPublicActions