Paths

Table of Contentst

[lib] Extract invite links actions
ClosedPublic
Actions

Authored by tomek on Jul 3 2023, 6:28 AM.

Details

Reviewers

kamil
inka
bartek

Commits

rCOMM88fc1560e536: [lib] Extract invite links actions

Summary

This logic is going to be used in a couple of places.

Depends on D8415

Test Plan

Check if manage links screen still works on native.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 3 2023, 6:28 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 3 2023, 6:28 AM

tomek added a child revision: D8417: [web] Call update or create invite link endpoint.Jul 3 2023, 6:33 AM

Harbormaster completed remote builds in B20685: Diff 28347.Jul 3 2023, 6:47 AM

tomek requested review of this revision.Jul 3 2023, 6:47 AM

inka accepted this revision.Jul 4 2023, 12:34 AM

inka added inline comments.

lib/hooks/invite-links.js
57 ↗	(On Diff #28347)	Why can't it just be `createOrUpdateInviteLink`? This name is not quite correct, and this just makes things confusing

This revision is now accepted and ready to land.Jul 4 2023, 12:34 AM

Rename

lib/hooks/invite-links.js
57 ↗	(On Diff #28347)	Makes sense!

Harbormaster completed remote builds in B20735: Diff 28408.Jul 5 2023, 4:36 AM

Closed by commit rCOMM88fc1560e536: [lib] Extract invite links actions (authored by tomek). · Explain WhyJul 10 2023, 5:49 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM88fc1560e536: [lib] Extract invite links actions.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

invite-links.js

105 lines

native/

invite-links/

manage-public-link-screen.react.js

82 lines

Diff 28540

View Options

lib/hooks/invite-links.js