Page MenuHomePhabricator
Differential D8416

[lib] Extract invite links actions
ClosedPublic
Actions

Authored by tomek on Jul 3 2023, 6:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 6:00 PM
Unknown Object (File)
Sat, Mar 15, 6:00 PM
Unknown Object (File)
Sat, Mar 15, 6:00 PM
Unknown Object (File)
Sat, Mar 15, 6:00 PM
Unknown Object (File)
Sat, Mar 15, 5:58 PM
Unknown Object (File)
Feb 20 2025, 4:30 AM
Unknown Object (File)
Feb 20 2025, 4:22 AM
Unknown Object (File)
Feb 18 2025, 6:28 AM
View All 82 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
bartek
Commits
rCOMM88fc1560e536: [lib] Extract invite links actions
Summary

This logic is going to be used in a couple of places.

Depends on D8415

Test Plan

Check if manage links screen still works on native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jul 3 2023, 6:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 3 2023, 6:28 AM
tomek added a child revision: D8417: [web] Call update or create invite link endpoint.Jul 3 2023, 6:33 AM
Harbormaster completed remote builds in B20685: Diff 28347.Jul 3 2023, 6:47 AM
tomek requested review of this revision.Jul 3 2023, 6:47 AM
inka accepted this revision.Jul 4 2023, 12:34 AM
inka added inline comments.
lib/hooks/invite-links.js
57 ↗(On Diff #28347)

Why can't it just be createOrUpdateInviteLink? This name is not quite correct, and this just makes things confusing

This revision is now accepted and ready to land.Jul 4 2023, 12:34 AM
tomek updated this revision to Diff 28408.Jul 5 2023, 4:19 AM

Rename

lib/hooks/invite-links.js
57 ↗(On Diff #28347)

Makes sense!

Harbormaster completed remote builds in B20735: Diff 28408.Jul 5 2023, 4:36 AM
Closed by commit rCOMM88fc1560e536: [lib] Extract invite links actions (authored by tomek). · Explain WhyJul 10 2023, 5:49 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM88fc1560e536: [lib] Extract invite links actions.

Revision Contents
Changeset List

PathSize
lib/
hooks/
105 lines
native/
invite-links/
82 lines

Diff 28540

View Options

lib/hooks/invite-links.js

Show All 30 Lines): Promise<FetchServerThreadInfosResult> {
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions
FROM threads t FROM threads t
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`.append(whereClause); `.append(whereClause);
const threadsQuery = SQL` const threadsQuery = SQL`
SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id, SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id,
t.community, t.depth, t.color, t.description, t.type, t.creation_time, t.community, t.depth, t.color, t.description, t.type, t.creation_time,
t.source_message, t.replies_count, t.avatar, m.user, m.role, m.permissions, t.source_message, t.replies_count, t.avatar, t.pinned_count, m.user,
m.subscription, m.last_read_message < m.last_message AS unread, m.sender m.role, m.permissions, m.subscription,
m.last_read_message < m.last_message AS unread, m.sender
FROM threads t FROM threads t
LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0 LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0
` `
.append(whereClause) .append(whereClause)
.append(SQL` ORDER BY m.user ASC`); .append(SQL` ORDER BY m.user ASC`);
const [[threadsResult], [rolesResult]] = await Promise.all([ const [[threadsResult], [rolesResult]] = await Promise.all([
dbQuery(threadsQuery), dbQuery(threadsQuery),
dbQuery(rolesQuery), dbQuery(rolesQuery),
]); ]);
Show All 16 Lines if (!threadInfos[threadID]) {
: null, : null,
depth: threadsRow.depth, depth: threadsRow.depth,
community: threadsRow.community community: threadsRow.community
? threadsRow.community.toString() ? threadsRow.community.toString()
: null, : null,
members: [], members: [],
roles: {}, roles: {},
repliesCount: threadsRow.replies_count, repliesCount: threadsRow.replies_count,
pinnedCount: threadsRow.pinned_count,
}; };
if (threadsRow.avatar) { if (threadsRow.avatar) {
threadInfos[threadID] = { threadInfos[threadID] = {
...threadInfos[threadID], ...threadInfos[threadID],
avatar: JSON.parse(threadsRow.avatar), avatar: JSON.parse(threadsRow.avatar),
}; };
} }
} }
▲ Show 20 Lines • Show All 75 Lines • ▼ Show 20 Lines const hasCodeVersionBelow104 = !hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
104, 104,
); );
// TODO (atul): Replace with `hasMinCodeVersion` check once we have a // TODO (atul): Replace with `hasMinCodeVersion` check once we have a
// native release with thread avatar editing enabled. // native release with thread avatar editing enabled.
const filterThreadEditAvatarPermission = true; const filterThreadEditAvatarPermission = true;
const hasCodeVersionBelow209 = !hasMinCodeVersion(
viewer.platformDetails,
209,
);
const threadInfos = {}; const threadInfos = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
includeVisibilityRules: hasCodeVersionBelow70, includeVisibilityRules: hasCodeVersionBelow70,
filterMemberList: hasCodeVersionBelow70, filterMemberList: hasCodeVersionBelow70,
shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null, shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null,
hideThreadStructure: hasCodeVersionBelow102, hideThreadStructure: hasCodeVersionBelow102,
filterDetailedThreadEditPermissions: hasCodeVersionBelow104, filterDetailedThreadEditPermissions: hasCodeVersionBelow104,
filterThreadEditAvatarPermission, filterThreadEditAvatarPermission,
excludePinInfo: hasCodeVersionBelow209,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

native/invite-links/manage-public-link-screen.react.js

Show All 30 Lines): Promise<FetchServerThreadInfosResult> {
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions
FROM threads t FROM threads t
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`.append(whereClause); `.append(whereClause);
const threadsQuery = SQL` const threadsQuery = SQL`
SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id, SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id,
t.community, t.depth, t.color, t.description, t.type, t.creation_time, t.community, t.depth, t.color, t.description, t.type, t.creation_time,
t.source_message, t.replies_count, t.avatar, m.user, m.role, m.permissions, t.source_message, t.replies_count, t.avatar, t.pinned_count, m.user,
m.subscription, m.last_read_message < m.last_message AS unread, m.sender m.role, m.permissions, m.subscription,
m.last_read_message < m.last_message AS unread, m.sender
FROM threads t FROM threads t
LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0 LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0
` `
.append(whereClause) .append(whereClause)
.append(SQL` ORDER BY m.user ASC`); .append(SQL` ORDER BY m.user ASC`);
const [[threadsResult], [rolesResult]] = await Promise.all([ const [[threadsResult], [rolesResult]] = await Promise.all([
dbQuery(threadsQuery), dbQuery(threadsQuery),
dbQuery(rolesQuery), dbQuery(rolesQuery),
]); ]);
Show All 16 Lines if (!threadInfos[threadID]) {
: null, : null,
depth: threadsRow.depth, depth: threadsRow.depth,
community: threadsRow.community community: threadsRow.community
? threadsRow.community.toString() ? threadsRow.community.toString()
: null, : null,
members: [], members: [],
roles: {}, roles: {},
repliesCount: threadsRow.replies_count, repliesCount: threadsRow.replies_count,
pinnedCount: threadsRow.pinned_count,
}; };
if (threadsRow.avatar) { if (threadsRow.avatar) {
threadInfos[threadID] = { threadInfos[threadID] = {
...threadInfos[threadID], ...threadInfos[threadID],
avatar: JSON.parse(threadsRow.avatar), avatar: JSON.parse(threadsRow.avatar),
}; };
} }
} }
▲ Show 20 Lines • Show All 75 Lines • ▼ Show 20 Lines const hasCodeVersionBelow104 = !hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
104, 104,
); );
// TODO (atul): Replace with `hasMinCodeVersion` check once we have a // TODO (atul): Replace with `hasMinCodeVersion` check once we have a
// native release with thread avatar editing enabled. // native release with thread avatar editing enabled.
const filterThreadEditAvatarPermission = true; const filterThreadEditAvatarPermission = true;
const hasCodeVersionBelow209 = !hasMinCodeVersion(
viewer.platformDetails,
209,
);
const threadInfos = {}; const threadInfos = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
includeVisibilityRules: hasCodeVersionBelow70, includeVisibilityRules: hasCodeVersionBelow70,
filterMemberList: hasCodeVersionBelow70, filterMemberList: hasCodeVersionBelow70,
shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null, shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null,
hideThreadStructure: hasCodeVersionBelow102, hideThreadStructure: hasCodeVersionBelow102,
filterDetailedThreadEditPermissions: hasCodeVersionBelow104, filterDetailedThreadEditPermissions: hasCodeVersionBelow104,
filterThreadEditAvatarPermission, filterThreadEditAvatarPermission,
excludePinInfo: hasCodeVersionBelow209,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines