Details

Reviewers

atul
ginsu

Commits

rCOMM086d723e3344: [native] Show Roles option in community action sheet

Summary

In the community action sheet, we want to introduce a 'Roles' option that will navigate to a screen listing all of the community roles and respective member counts. Since that involves navigation, the action key/value will come later, and this just shows the option in the action sheet (the entire stack will be landed together, so this won't be an issue).

Depends on D8332

ENG-4166

Test Plan

Confirm that a 'Roles' option appears for those who have permissions to change roles, and it should not appear if otherwise.

Simulator Screen Shot - iPhone 14 Pro - 2023-06-27 at 11.22.55.png (2×1 px, 403 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 27 2023, 8:21 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2023, 8:21 AM

rohan edited the summary of this revision. (Show Details)Jun 27 2023, 8:21 AM

rohan edited the summary of this revision. (Show Details)

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F609424: Simulator Screen Shot - iPhone 14 Pro - 2023-06-27 at 11.22.55.png. (Show Details)Jun 27 2023, 8:23 AM

Harbormaster completed remote builds in B20546: Diff 28178.Jun 27 2023, 8:39 AM

rohan requested review of this revision.Jun 27 2023, 8:39 AM

rohan added a child revision: D8335: [native] Create a roles navigator to handle the role creation flow.Jun 27 2023, 8:40 AM

atul accepted this revision.Jun 27 2023, 9:21 AM

atul added inline comments.

native/components/community-actions-button.react.js
87 ↗	(On Diff #28178)	Should it be "Roles" or "Manage Roles" for symmetry w/ "Manage Invite Links" CC @ashoat for copy

This revision is now accepted and ready to land.Jun 27 2023, 9:21 AM

Please always check with me about any copy you get from @ted

native/components/community-actions-button.react.js
69 ↗	(On Diff #28178)	This copy should have never shipped. In other places we use lowercase (eg. "Create new subchannel"). I suspect @ted's copy was taken without checking with me on this one... as it is right now, developers need to be extremely critical and careful with any copy they get from @ted Can you update this diff to make it lowercase? cc @tomek
76 ↗	(On Diff #28178)	Lowercase
87 ↗	(On Diff #28178)	Let's go with `Manage roles`

tomek added inline comments.Jun 29 2023, 5:48 AM

native/components/community-actions-button.react.js
69 ↗	(On Diff #28178)	Yeah, that was the case - sorry for that. But I'm wondering if it could be more efficient if the copies were approved before giving the design to a developer to implement it.