Differential D8366

[Keyserver/rust] Add device login and register
ClosedPublic
Actions

Authored by • jon on Jun 28 2023, 3:59 PM.

Tags

None

Referenced Files

	F3515583: D8366.diff
	Sun, Dec 22, 9:15 AM

	Unknown Object (File)
	Sun, Dec 15, 3:59 AM

	Unknown Object (File)
	Sun, Dec 15, 3:59 AM

	Unknown Object (File)
	Sun, Dec 15, 3:59 AM

	Unknown Object (File)
	Sun, Dec 15, 3:59 AM

	Unknown Object (File)
	Sun, Dec 15, 3:59 AM

	Unknown Object (File)
	Sun, Dec 15, 3:45 AM

	Unknown Object (File)
	Sat, Dec 7, 6:24 AM

Subscribers

Details

Reviewers

bartek
varun

Commits

rCOMMaf11c5973624: [Keyserver/rust] Add device login and register

Summary

Rust portion of keyserver login/register.
Largely adapted from integration tests.

Depends on D8365 D8052

Test Plan

Tested in later diff

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jun 28 2023, 3:59 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2023, 3:59 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 28 2023, 4:05 PM

Harbormaster failed remote builds in B20600: Diff 28239!

Rebase on master, minor fixes

• jon added a child revision: D8399: [Keyserver/rust] Ignore debug version of napi build.Jun 30 2023, 3:26 PM

Harbormaster completed remote builds in B20658: Diff 28314.Jun 30 2023, 3:40 PM

• jon requested review of this revision.Jun 30 2023, 3:41 PM

bartek added inline comments.Jun 30 2023, 11:18 PM

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs
12–22	I'm missing some context - Why do we delete this?

• jon removed a parent revision: D8052: [Keyserver] Use olm identity key for tunnelbroker connection.Jul 3 2023, 7:12 AM

• jon added inline comments.Jul 4 2023, 1:08 PM

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs
12–22	Similar to D8404 , this service is longer provided by identity service. It existed for a while for keyserver to register/login users on their behalf. But has since been removed in identity service. It should have been deleted in D7390
74	clones might not be necessary, since registration_response also falls out of scope after this.

bartek accepted this revision.Jul 4 2023, 1:10 PM

bartek added inline comments.

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs
12–22	Thanks for explaining!
74	yeah, let's get rid of them if possible

This revision is now accepted and ready to land.Jul 4 2023, 1:10 PM

Address feedback, rebase

Harbormaster completed remote builds in B20765: Diff 28441.Jul 6 2023, 9:54 AM

• jon removed a parent revision: D8052: [Keyserver] Use olm identity key for tunnelbroker connection.Jul 6 2023, 10:13 AM

• jon marked 3 inline comments as done.

Closed by commit rCOMMaf11c5973624: [Keyserver/rust] Add device login and register (authored by • jon). · Explain WhyJul 6 2023, 10:22 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMaf11c5973624: [Keyserver/rust] Add device login and register.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

rust-binding-types.js

24 lines

src/

identity_client/

77 lines

11 lines

register_user.rs

46 lines

Diff 28314

keyserver/addons/rust-node-addon/rust-binding-types.js

Loading...

keyserver/addons/rust-node-addon/src/identity_client/login.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

Loading...