Paths

Table of Contentst

Differential D8487

[native] replace `folly::Optional` with `std::optional`
ClosedPublic
Actions

Authored by kamil on Jul 12 2023, 1:15 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

michal
tomek
• jon
atul
marcin

Commits

rCOMMa3388afb3ec8: [native] replace `folly::Optional` with `std::optional`

Summary

The point is to avoid adding folly dependency on web.

Emscripten C++17 compatibility will be handled in subsequent diff.

Depends on D8472

Test Plan

Log out
Call getOlmPersistAccountData() -> should return nullopt`
Log in
Call getOlmPersistAccountData()` -> should return string
Tested on both iOS and Android.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 12 2023, 1:15 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 12 2023, 1:15 PM

kamil added a child revision: D8488: [nix] Enable C++17 support for Emscripten.Jul 12 2023, 1:18 PM

Harbormaster completed remote builds in B20902: Diff 28633.Jul 12 2023, 1:32 PM

kamil published this revision for review.Jul 12 2023, 2:36 PM

michal added inline comments.Jul 14 2023, 9:21 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
944–946 ↗	(On Diff #28633)	I think this didn't need to be changed (std::optional also has ->), but I haven't used it personally, so maybe there is some difference, and it doesn't really matter anyway.

michal accepted this revision.Jul 14 2023, 9:21 AM

This revision is now accepted and ready to land.Jul 14 2023, 9:21 AM

kamil added a reviewer: marcin.Jul 17 2023, 9:25 AM

This revision now requires review to proceed.Jul 17 2023, 9:25 AM

tomek accepted this revision.Jul 17 2023, 11:43 AM

marcin accepted this revision.Jul 18 2023, 8:43 AM

This revision is now accepted and ready to land.Jul 18 2023, 8:43 AM

kamil removed a parent revision: D8472: [native] add entity and methods for redux-persist storage.Jul 19 2023, 1:46 PM

use -> operator

kamil removed a parent revision: D8472: [native] add entity and methods for redux-persist storage.Jul 20 2023, 1:33 PM

Harbormaster completed remote builds in B21084: Diff 28886.Jul 20 2023, 1:50 PM

Closed by commit rCOMMa3388afb3ec8: [native] replace `folly::Optional` with `std::optional`. · Explain WhyJul 20 2023, 1:56 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa3388afb3ec8: [native] replace `folly::Optional` with `std::optional`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

2 lines

SQLiteQueryExecutor.h

2 lines

SQLiteQueryExecutor.cpp

6 lines

NativeModules/

CommCoreModule.cpp

4 lines

Diff 28887

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...