[native] Show a menu button next to each role except admins
ClosedPublic
Actions

Authored by rohan on Jul 17 2023, 10:24 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMMdb27cc19891a: [native] Show a menu button next to each role except admins

Summary

To prepare for editing and deleting roles, we want to display a menu button next to each role except for admins. It's safe to check by name here since the Admins role cannot be renamed, but it's worth noting that a more sound check would be what is described in ENG-4155. For now though, I don't think it makes sense to
prioritize this and will be easy enough to update down the line once ENG-4155 is complete

Part of ENG-4367.

Depends on D8502

Test Plan

Confirmed that the menu button displays for Members and custom roles, but not Admins

Simulator Screen Shot - iPhone 14 Pro - 2023-07-17 at 13.24.28.png (2×1 px, 153 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Jul 17 2023, 10:24 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 17 2023, 10:24 AM

rohan edited the summary of this revision. (Show Details)Jul 17 2023, 10:24 AM

rohan edited the test plan for this revision. (Show Details)

rohan edited the summary of this revision. (Show Details)Jul 17 2023, 10:40 AM

Harbormaster completed remote builds in B20976: Diff 28759.Jul 17 2023, 10:42 AM

rohan requested review of this revision.Jul 17 2023, 10:42 AM

rohan added a child revision: D8523: [native] Display an action sheet with the 'edit role' option.Jul 17 2023, 10:44 AM

ginsu requested changes to this revision.Jul 20 2023, 3:01 PM

ginsu added inline comments.

native/roles/role-panel-entry.react.js
41	I think it would make more sense for `TouchableOpacity` to be only wrapping the icon. If the menu button is "empty" then we shouldn't need `TouchableOpacity` too right?