Page MenuHomePhabricator

[native] introduce functionality to send a reaction by pressing on the reaction pill.
ClosedPublic

Authored by ginsu on Jul 19 2023, 3:09 PM.
Tags
None
Referenced Files
F3388132: D8578.diff
Fri, Nov 29, 12:56 PM
Unknown Object (File)
Sat, Nov 23, 12:52 PM
Unknown Object (File)
Sat, Nov 23, 12:52 PM
Unknown Object (File)
Fri, Nov 8, 3:18 PM
Unknown Object (File)
Fri, Nov 8, 12:52 PM
Unknown Object (File)
Fri, Nov 8, 12:10 PM
Unknown Object (File)
Fri, Nov 8, 11:51 AM
Unknown Object (File)
Oct 28 2024, 5:36 AM
Subscribers

Details

Summary

To improve the user experience of the InlineEngagement component we are updating the pressing behavior for our reaction pills. Before whenever a user would press on a reaction, the MessageReactionsModal would slide in, but now if a user presses a reaction they will react/unreact to that message depending on whether or not they have already reacted to that message already. To view the MessageReactionsModal the user now needs to long press on the reaction pill (a similar pattern with other chat apps such as discord and slack)

Depends on D8576

Test Plan

Please watch the demo below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Jul 19 2023, 3:51 PM

This new functionality is awesome

This revision is now accepted and ready to land.Jul 24 2023, 1:56 AM
This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM
This revision was automatically updated to reflect the committed changes.