Page MenuHomePhabricator
Differential D8624

[web] Push the create role modal with prepopulated fields when Edit Role is clicked
ClosedPublic
Actions

Authored by rohan on Jul 25 2023, 8:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:28 PM
Unknown Object (File)
Sat, Nov 9, 11:21 PM
Unknown Object (File)
Sat, Nov 9, 11:21 PM
Unknown Object (File)
Sat, Nov 9, 10:50 PM
Unknown Object (File)
Sat, Nov 9, 9:11 PM
Unknown Object (File)
Sat, Nov 9, 4:18 PM
Unknown Object (File)
Thu, Nov 7, 6:00 PM
Unknown Object (File)
Oct 7 2024, 9:45 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMbdab982a2130: [web] Push the create role modal with prepopulated fields when Edit Role is…
Summary

This diff essentially handles the edit role workflow on web, where the permission enum options will be pre-selected if previously selected. The logic is similar to what was done in D8524 on native. The keyserver logic for handling editing roles is already done earlier in the stack

ENG-4430

Depends on D8623

Test Plan

Verified that the modal is opened with the correct pre-populated fields after creating a new role then trying to edit it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Jul 25 2023, 8:13 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2023, 8:13 AM
rohan edited the test plan for this revision. (Show Details)Jul 25 2023, 8:19 AM
rohan edited the summary of this revision. (Show Details)
rohan added a child revision: D8625: [web] Create the modals that will allow the user to confirm role deletion.Jul 25 2023, 8:23 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2023, 8:45 AM
Harbormaster failed remote builds in B21188: Diff 29023!
Harbormaster completed remote builds in B21188: Diff 29023.Jul 25 2023, 9:41 AM
rohan requested review of this revision.Jul 25 2023, 9:41 AM
atul accepted this revision.Jul 26 2023, 11:17 AM
This revision is now accepted and ready to land.Jul 26 2023, 11:17 AM
rohan updated this revision to Diff 29070.Jul 26 2023, 11:57 AM

Rebase

Harbormaster completed remote builds in B21226: Diff 29070.Jul 26 2023, 12:18 PM
rohan updated this revision to Diff 29101.Jul 27 2023, 2:36 AM

Rebase

Harbormaster completed remote builds in B21257: Diff 29101.Jul 27 2023, 3:10 AM
rohan updated this revision to Diff 29343.Jul 31 2023, 12:06 PM

Rebase

This revision was landed with ongoing or failed builds.Jul 31 2023, 6:15 PM
Closed by commit rCOMMbdab982a2130: [web] Push the create role modal with prepopulated fields when Edit Role is… (authored by rohan). · Explain Why
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMMbdab982a2130: [web] Push the create role modal with prepopulated fields when Edit Role is….
Harbormaster completed remote builds in B21431: Diff 29343.Jul 31 2023, 9:56 PM

Revision Contents
Changeset List

Diff 29101

View Options

web/roles/create-roles-modal.react.js

Loading...
View Options

web/roles/role-actions-menu.react.js

Loading...