[lib/native] update heightMeasurerKey function to consider inline engagement for robotext messages
ClosedPublic
Actions

Authored by ginsu on Jul 25 2023, 12:23 PM.

Details

Reviewers

kamil
ashoat
tomek
atul

Commits

rCOMMf29bf4eed7b4: [lib/native] update heightMeasurerKey function to consider inline engagement…

Summary

This next diff updates the heightMeasurerKey function so that we remeasure a message whenever there is a change with the inline engagement for that message. In this diff we want to also consider changes to sidebar text and the reactions since these can all potentially affect the height of the inline engagement node

Depends on D8610

Test Plan

I tested modifying the height of the inline engagement for robotext messages, and when I did this, I no longer got the incorrect height measurement logs from the console

Before:

After:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 25 2023, 12:23 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2023, 12:23 PM

added @ashoat and @tomek as reviewers since they have the most context on height measurement

Harbormaster completed remote builds in B21196: Diff 29032.Jul 25 2023, 12:39 PM

ginsu requested review of this revision.Jul 25 2023, 12:39 PM

ginsu added a child revision: D8629: [lib/native/web] update getMessageLabel parameters.Jul 25 2023, 1:05 PM

atul resigned from this revision.Jul 25 2023, 11:32 PM

tomek accepted this revision.Jul 26 2023, 3:14 AM

tomek added inline comments.

lib/shared/inline-engagement-utils.js
17–18 ↗	(On Diff #29032)	We probably don't have good guarantees about iteration order, but it should be fine as we're caring here only about changes in the object.