[keyserver/lib] Introduce the thread actions, endpoints, and responders for deleting a custom role
ClosedPublic
Actions

Authored by rohan on Jul 26 2023, 8:23 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM20d4bdbdbbc5: [keyserver/lib] Introduce the thread actions, endpoints, and responders for…

Summary

Split into separate diffs from D8574, this diff handles introducing the actions, responders, and endpoints for deleting a custom role. This, alongside the core delete function from D8574 will be all
of the back-end needed for deleting roles.

Depends on D8574

Test Plan

This will be tested with the client-side logic introduced in the next diff (split out from D8574)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Jul 26 2023, 8:23 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 26 2023, 8:23 AM

rohan added a child revision: D8640: [native] Introduce client-side logic for deleting roles on native.Jul 26 2023, 8:26 AM

rohan mentioned this in D8574: [keyserver/lib] Enable the option to delete custom roles.Jul 26 2023, 8:28 AM

Harbormaster completed remote builds in B21217: Diff 29061.Jul 26 2023, 8:40 AM

rohan requested review of this revision.Jul 26 2023, 8:40 AM

Didn't look at implementation of deleteRole(...), but this looks correct assuming that deleteRole(...) is.

This revision is now accepted and ready to land.Jul 26 2023, 11:58 AM

atul added inline comments.Jul 26 2023, 12:00 PM

keyserver/src/responders/thread-responders.js
395	These guys are really easy to write unit tests for. They may not be particularly useful, but maybe you'll get more familiar w/ Jest and writing tests will be more approachable in the future? idk