Page MenuHomePhabricator
Differential D8999

[client-backup] implement function to encrypt backup
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:38 AM.
Tags
None
Referenced Files
F6182541: D8999.id30678.diff
Wed, Apr 23, 7:53 AM
Unknown Object (File)
Mon, Apr 21, 5:14 AM
Unknown Object (File)
Thu, Apr 17, 7:30 PM
Unknown Object (File)
Wed, Apr 9, 9:26 AM
Unknown Object (File)
Fri, Apr 4, 2:46 PM
Unknown Object (File)
Fri, Apr 4, 1:53 PM
Unknown Object (File)
Fri, Apr 4, 2:35 AM
Unknown Object (File)
Thu, Apr 3, 9:57 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
Commits
rCOMM02d810fbf320: [client-backup] implement function to encrypt backup
Summary

Implementing backup encryption with AES-256 in GCM mode.

Depends on D8998

Test Plan

Tested with next diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 2:38 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:38 AM
kamil added a child revision: D9000: [client-backup] implement functions to decrypt backup.Aug 29 2023, 2:41 AM
Harbormaster completed remote builds in B22202: Diff 30478.Aug 29 2023, 2:54 AM
kamil published this revision for review.Aug 29 2023, 3:22 AM
kamil added inline comments.
native/backup/encryption.js
29 ↗(On Diff #30478)

ct1 and ct2 is a whitepaper notation

marcin accepted this revision.Aug 29 2023, 6:37 AM
This revision is now accepted and ready to land.Aug 29 2023, 6:37 AM
bartek accepted this revision.Aug 29 2023, 6:43 AM
Closed by commit rCOMM02d810fbf320: [client-backup] implement function to encrypt backup (authored by kamil). · Explain WhyAug 31 2023, 1:53 PM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM02d810fbf320: [client-backup] implement function to encrypt backup.

Revision Contents
Changeset List

PathSize
native/
backup/
8 lines
20 lines

Diff 30678

View Options

native/backup/conversion-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { messageID } from './message-utils.js';
import SearchIndex from './search-index.js'; import SearchIndex from './search-index.js';
import { import {
userIsMember, userIsMember,
threadMemberHasPermission, threadMemberHasPermission,
getContainingThreadID, getContainingThreadID,
} from './thread-utils.js'; } from './thread-utils.js';
import { import {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
searchMessagesActionTypes, searchMessagesActionTypes,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
ChatMessageItem,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import { isComposableMessageType } from '../types/message-types.js';
import type { MinimallyEncodedThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { MinimallyEncodedThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import { type ThreadInfo } from '../types/thread-types.js'; import { type ThreadInfo } from '../types/thread-types.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
UserListItem, UserListItem,
▲ Show 20 Lines • Show All 97 Lines • ▼ Show 20 Linesfunction getPotentialMemberItems({
const blockedRelationshipsStatuses = new Set([ const blockedRelationshipsStatuses = new Set([
userRelationshipStatus.BLOCKED_BY_VIEWER, userRelationshipStatus.BLOCKED_BY_VIEWER,
userRelationshipStatus.BLOCKED_VIEWER, userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED, userRelationshipStatus.BOTH_BLOCKED,
]); ]);
let userResults = values(results); let userResults = values(results);
if (text === '') { if (text === '') {
userResults = userResults.filter(userInfo => userResults = userResults.filter(userInfo => {
containingThreadInfo if (!containingThreadInfo) {
? userInfo.isMemberOfContainingThread && return userInfo.relationshipStatus === userRelationshipStatus.FRIEND;
!blockedRelationshipsStatuses.has(userInfo.relationshipStatus) }
: userInfo?.relationshipStatus === userRelationshipStatus.FRIEND, if (!userInfo.isMemberOfContainingThread) {
); return false;
}
const { relationshipStatus } = userInfo;
if (!relationshipStatus) {
return true;
}
return !blockedRelationshipsStatuses.has(relationshipStatus);
});
} }
const nonFriends = []; const nonFriends = [];
const blockedUsers = []; const blockedUsers = [];
const friends = []; const friends = [];
const containingThreadMembers = []; const containingThreadMembers = [];
const parentThreadMembers = []; const parentThreadMembers = [];
for (const userResult of userResults) { for (const userResult of userResults) {
const relationshipStatus = userResult.relationshipStatus; const { relationshipStatus } = userResult;
if (blockedRelationshipsStatuses.has(relationshipStatus)) { if (
relationshipStatus &&
blockedRelationshipsStatuses.has(relationshipStatus)
) {
blockedUsers.push(userResult); blockedUsers.push(userResult);
} else if (userResult.isMemberOfParentThread) { } else if (userResult.isMemberOfParentThread) {
parentThreadMembers.push(userResult); parentThreadMembers.push(userResult);
} else if (userResult.isMemberOfContainingThread) { } else if (userResult.isMemberOfContainingThread) {
containingThreadMembers.push(userResult); containingThreadMembers.push(userResult);
} else if (relationshipStatus === userRelationshipStatus.FRIEND) { } else if (relationshipStatus === userRelationshipStatus.FRIEND) {
friends.push(userResult); friends.push(userResult);
} else { } else {
Show All 11 Lines return sortedResults.map(
({ ({
isMemberOfContainingThread, isMemberOfContainingThread,
isMemberOfParentThread, isMemberOfParentThread,
relationshipStatus, relationshipStatus,
...result ...result
}) => { }) => {
let notice, alert; let notice, alert;
const username = result.username; const username = result.username;
if (blockedRelationshipsStatuses.has(relationshipStatus)) { if (
relationshipStatus &&
blockedRelationshipsStatuses.has(relationshipStatus)
) {
notice = 'user is blocked'; notice = 'user is blocked';
alert = { alert = {
title: 'User is blocked', title: 'User is blocked',
text: text:
`Before you add ${username} to this chat, ` + `Before you add ${username} to this chat, ` +
'you’ll need to unblock them. You can do this from the Block List ' + 'you’ll need to unblock them. You can do this from the Block List ' +
'in the Profile tab.', 'in the Profile tab.',
}; };
▲ Show 20 Lines • Show All 114 Lines • ▼ Show 20 Lines
function filterChatMessageInfosForSearch( function filterChatMessageInfosForSearch(
chatMessageInfos: MessageListData, chatMessageInfos: MessageListData,
translatedSearchResults: $ReadOnlyArray<MessageInfo>, translatedSearchResults: $ReadOnlyArray<MessageInfo>,
): ?(ChatMessageInfoItem[]) { ): ?(ChatMessageInfoItem[]) {
if (!chatMessageInfos) { if (!chatMessageInfos) {
return null; return null;
} }
const idSet = new Set(translatedSearchResults.map(item => item.id)); const idSet = new Set(translatedSearchResults.map(messageID));
const chatMessageInfoItems = chatMessageInfos.filter(
item =>
item.messageInfo &&
idSet.has(item.messageInfo.id) &&
isComposableMessageType(item.messageInfo.type),
);
const uniqueChatMessageInfoItemsMap = new Map<string, ChatMessageItem>(); const uniqueChatMessageInfoItemsMap = new Map<string, ChatMessageInfoItem>();
chatMessageInfoItems.forEach( for (const item of chatMessageInfos) {
item => if (item.itemType !== 'message' || item.messageInfoType !== 'composable') {
item.messageInfo && continue;
item.messageInfo.id && }
uniqueChatMessageInfoItemsMap.set(item.messageInfo.id, item), const id = messageID(item.messageInfo);
); if (idSet.has(id)) {
uniqueChatMessageInfoItemsMap.set(id, item);
}
}
const sortedChatMessageInfoItems = []; const sortedChatMessageInfoItems: ChatMessageInfoItem[] = [];
for (let i = 0; i < translatedSearchResults.length; i++) { for (let i = 0; i < translatedSearchResults.length; i++) {
sortedChatMessageInfoItems.push( const id = messageID(translatedSearchResults[i]);
uniqueChatMessageInfoItemsMap.get(translatedSearchResults[i].id), const match = uniqueChatMessageInfoItemsMap.get(id);
); if (match) {
sortedChatMessageInfoItems.push(match);
} }
}
return sortedChatMessageInfoItems.filter(Boolean); return sortedChatMessageInfoItems;
} }
export { export {
getPotentialMemberItems, getPotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
}; };
View Options

native/backup/encryption.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { messageID } from './message-utils.js';
import SearchIndex from './search-index.js'; import SearchIndex from './search-index.js';
import { import {
userIsMember, userIsMember,
threadMemberHasPermission, threadMemberHasPermission,
getContainingThreadID, getContainingThreadID,
} from './thread-utils.js'; } from './thread-utils.js';
import { import {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
searchMessagesActionTypes, searchMessagesActionTypes,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
ChatMessageItem,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import { isComposableMessageType } from '../types/message-types.js';
import type { MinimallyEncodedThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { MinimallyEncodedThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import { type ThreadInfo } from '../types/thread-types.js'; import { type ThreadInfo } from '../types/thread-types.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
UserListItem, UserListItem,
▲ Show 20 Lines • Show All 97 Lines • ▼ Show 20 Linesfunction getPotentialMemberItems({
const blockedRelationshipsStatuses = new Set([ const blockedRelationshipsStatuses = new Set([
userRelationshipStatus.BLOCKED_BY_VIEWER, userRelationshipStatus.BLOCKED_BY_VIEWER,
userRelationshipStatus.BLOCKED_VIEWER, userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED, userRelationshipStatus.BOTH_BLOCKED,
]); ]);
let userResults = values(results); let userResults = values(results);
if (text === '') { if (text === '') {
userResults = userResults.filter(userInfo => userResults = userResults.filter(userInfo => {
containingThreadInfo if (!containingThreadInfo) {
? userInfo.isMemberOfContainingThread && return userInfo.relationshipStatus === userRelationshipStatus.FRIEND;
!blockedRelationshipsStatuses.has(userInfo.relationshipStatus) }
: userInfo?.relationshipStatus === userRelationshipStatus.FRIEND, if (!userInfo.isMemberOfContainingThread) {
); return false;
}
const { relationshipStatus } = userInfo;
if (!relationshipStatus) {
return true;
}
return !blockedRelationshipsStatuses.has(relationshipStatus);
});
} }
const nonFriends = []; const nonFriends = [];
const blockedUsers = []; const blockedUsers = [];
const friends = []; const friends = [];
const containingThreadMembers = []; const containingThreadMembers = [];
const parentThreadMembers = []; const parentThreadMembers = [];
for (const userResult of userResults) { for (const userResult of userResults) {
const relationshipStatus = userResult.relationshipStatus; const { relationshipStatus } = userResult;
if (blockedRelationshipsStatuses.has(relationshipStatus)) { if (
relationshipStatus &&
blockedRelationshipsStatuses.has(relationshipStatus)
) {
blockedUsers.push(userResult); blockedUsers.push(userResult);
} else if (userResult.isMemberOfParentThread) { } else if (userResult.isMemberOfParentThread) {
parentThreadMembers.push(userResult); parentThreadMembers.push(userResult);
} else if (userResult.isMemberOfContainingThread) { } else if (userResult.isMemberOfContainingThread) {
containingThreadMembers.push(userResult); containingThreadMembers.push(userResult);
} else if (relationshipStatus === userRelationshipStatus.FRIEND) { } else if (relationshipStatus === userRelationshipStatus.FRIEND) {
friends.push(userResult); friends.push(userResult);
} else { } else {
Show All 11 Lines return sortedResults.map(
({ ({
isMemberOfContainingThread, isMemberOfContainingThread,
isMemberOfParentThread, isMemberOfParentThread,
relationshipStatus, relationshipStatus,
...result ...result
}) => { }) => {
let notice, alert; let notice, alert;
const username = result.username; const username = result.username;
if (blockedRelationshipsStatuses.has(relationshipStatus)) { if (
relationshipStatus &&
blockedRelationshipsStatuses.has(relationshipStatus)
) {
notice = 'user is blocked'; notice = 'user is blocked';
alert = { alert = {
title: 'User is blocked', title: 'User is blocked',
text: text:
`Before you add ${username} to this chat, ` + `Before you add ${username} to this chat, ` +
'you’ll need to unblock them. You can do this from the Block List ' + 'you’ll need to unblock them. You can do this from the Block List ' +
'in the Profile tab.', 'in the Profile tab.',
}; };
▲ Show 20 Lines • Show All 114 Lines • ▼ Show 20 Lines
function filterChatMessageInfosForSearch( function filterChatMessageInfosForSearch(
chatMessageInfos: MessageListData, chatMessageInfos: MessageListData,
translatedSearchResults: $ReadOnlyArray<MessageInfo>, translatedSearchResults: $ReadOnlyArray<MessageInfo>,
): ?(ChatMessageInfoItem[]) { ): ?(ChatMessageInfoItem[]) {
if (!chatMessageInfos) { if (!chatMessageInfos) {
return null; return null;
} }
const idSet = new Set(translatedSearchResults.map(item => item.id)); const idSet = new Set(translatedSearchResults.map(messageID));
const chatMessageInfoItems = chatMessageInfos.filter(
item =>
item.messageInfo &&
idSet.has(item.messageInfo.id) &&
isComposableMessageType(item.messageInfo.type),
);
const uniqueChatMessageInfoItemsMap = new Map<string, ChatMessageItem>(); const uniqueChatMessageInfoItemsMap = new Map<string, ChatMessageInfoItem>();
chatMessageInfoItems.forEach( for (const item of chatMessageInfos) {
item => if (item.itemType !== 'message' || item.messageInfoType !== 'composable') {
item.messageInfo && continue;
item.messageInfo.id && }
uniqueChatMessageInfoItemsMap.set(item.messageInfo.id, item), const id = messageID(item.messageInfo);
); if (idSet.has(id)) {
uniqueChatMessageInfoItemsMap.set(id, item);
}
}
const sortedChatMessageInfoItems = []; const sortedChatMessageInfoItems: ChatMessageInfoItem[] = [];
for (let i = 0; i < translatedSearchResults.length; i++) { for (let i = 0; i < translatedSearchResults.length; i++) {
sortedChatMessageInfoItems.push( const id = messageID(translatedSearchResults[i]);
uniqueChatMessageInfoItemsMap.get(translatedSearchResults[i].id), const match = uniqueChatMessageInfoItemsMap.get(id);
); if (match) {
sortedChatMessageInfoItems.push(match);
} }
}
return sortedChatMessageInfoItems.filter(Boolean); return sortedChatMessageInfoItems;
} }
export { export {
getPotentialMemberItems, getPotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
}; };