Page MenuHomePhabricator
Differential D9105

[web] Hide databaseModule behind a function
ClosedPublic
Actions

Authored by michal on Sep 8 2023, 4:02 AM.
Tags
None
Referenced Files
F1800568: D9105.diff
Mon, May 20, 6:26 AM
Unknown Object (File)
Thu, May 16, 6:13 AM
Unknown Object (File)
Mon, May 13, 2:53 PM
Unknown Object (File)
Tue, May 7, 8:31 AM
Unknown Object (File)
Apr 5 2024, 11:24 AM
Unknown Object (File)
Apr 5 2024, 11:24 AM
Unknown Object (File)
Apr 5 2024, 11:24 AM
Unknown Object (File)
Apr 5 2024, 11:20 AM
View All 31 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
inka
atul
Commits
rCOMMc67113dafe68: [web] Hide databaseModule behind a function
Summary

Part of ENG-4844
When database will be used by all users (including anonymous ones), we need to make sure that it's never in an unitialized state. We hide it behind a getter function so we add the initialization code there in the later diffs.

Test Plan

yarn flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Sep 8 2023, 4:02 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 8 2023, 4:02 AM
michal added a reviewer: atul.Sep 8 2023, 4:10 AM
michal added a child revision: D9107: [web] Move safari db key init to database module.Sep 8 2023, 4:13 AM
michal added inline comments.Sep 8 2023, 4:14 AM
web/database/database-module-provider.js
125 ↗(On Diff #30854)

async will be used in the later diffs

Harbormaster completed remote builds in B22438: Diff 30854.Sep 8 2023, 4:19 AM
michal requested review of this revision.Sep 8 2023, 4:19 AM
tomek accepted this revision.Sep 8 2023, 5:34 AM
kamil accepted this revision.Sep 10 2023, 11:35 PM
This revision is now accepted and ready to land.Sep 10 2023, 11:35 PM
kamil mentioned this in D9109: [web] Enable db for all users.Sep 11 2023, 12:30 AM
Closed by commit rCOMMc67113dafe68: [web] Hide databaseModule behind a function (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 18 2023, 3:26 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMc67113dafe68: [web] Hide databaseModule behind a function.

Revision Contents
Changeset List

Diff 31192

View Options

web/database/database-module-provider.js

Loading...
View Options

web/database/sqlite-data-handler.js

Loading...
View Options

web/redux/comm-redux-storage-engine.js

Loading...
View Options

web/redux/persist.js

Loading...
View Options

web/redux/redux-setup.js

Loading...