Page MenuHomePhabricator
Differential D9285

[native] simplify RelationshipListItem jsx
ClosedPublic
Actions

Authored by ginsu on Sep 25 2023, 6:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 12:24 AM
Unknown Object (File)
Sun, Nov 10, 7:57 PM
Unknown Object (File)
Sun, Nov 10, 12:26 AM
Unknown Object (File)
Fri, Nov 1, 8:43 PM
Unknown Object (File)
Fri, Nov 1, 8:43 PM
Unknown Object (File)
Fri, Nov 1, 8:43 PM
Unknown Object (File)
Fri, Nov 1, 8:36 PM
Unknown Object (File)
Wed, Oct 23, 4:57 AM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMc610c2ea44ac: [native] simplify RelationshipListItem jsx
Summary

Small refactor diff to simplify the JSX being returned in RelationshipListItem

Test Plan

Confirmed that RelationshipListItem still looks and behaves the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 25 2023, 6:38 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 25 2023, 6:38 AM
Harbormaster completed remote builds in B22828: Diff 31398.Sep 25 2023, 6:56 AM
ginsu requested review of this revision.Sep 25 2023, 6:56 AM
ginsu added a child revision: D9286: [native] make user profiles accessible from RelationshipListItem.Sep 25 2023, 7:11 AM
ginsu added reviewers: atul, inka.Sep 26 2023, 11:40 AM
atul requested changes to this revision.Sep 26 2023, 2:07 PM

Let's memoize that style object (array)

native/profile/relationship-list-item.react.js
169 ↗(On Diff #31398)

Let's memoize

274 ↗(On Diff #31398)

Seems like the right color family

This revision now requires changes to proceed.Sep 26 2023, 2:07 PM
ginsu requested review of this revision.Sep 27 2023, 3:33 PM
ginsu added inline comments.
native/profile/relationship-list-item.react.js
169 ↗(On Diff #31398)

This is actually a class component, so we don't need to memoize this style. Sorry I can see that it could be hard to tell in this view, and probably should have put an inline comment to make it very clear

atul accepted this revision.Sep 27 2023, 4:26 PM
This revision is now accepted and ready to land.Sep 27 2023, 4:26 PM
ginsu updated this revision to Diff 31833.Oct 9 2023, 1:54 PM

rebase before landing

Harbormaster completed remote builds in B23126: Diff 31833.Oct 9 2023, 2:11 PM
Closed by commit rCOMMc610c2ea44ac: [native] simplify RelationshipListItem jsx (authored by ginsu). · Explain WhyOct 9 2023, 2:18 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc610c2ea44ac: [native] simplify RelationshipListItem jsx.

Revision Contents
Changeset List

PathSize
native/
profile/
29 lines

Diff 31846

View Options

native/profile/relationship-list-item.react.js

Loading...