[native] fix viewer user profile bototm sheet snap point
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 5:38 AM.

Details

Reviewers

atul
inka

Commits

rCOMM6794479a1d26: [native] fix viewer user profile bototm sheet snap point

Summary

This fixes a small bug with our user profile bottom sheet snap point logic when a viewer was viewing their own user profile

Depends on D9394

Test Plan

Please see the screenshots below

Before:

Screenshot 2023-10-06 at 8.40.41 AM.png (1×1 px, 800 KB)

After:

Screenshot 2023-10-06 at 8.40.12 AM.png (1×1 px, 810 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 6 2023, 5:38 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 5:38 AM

ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 5:41 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9394: [native] introduce MarkdownUserMention component.

ginsu attached a referenced file: F794551: Screenshot 2023-10-06 at 8.40.12 AM.png. (Show Details)

ginsu attached a referenced file: F794548: Screenshot 2023-10-06 at 8.40.41 AM.png. (Show Details)

ginsu added inline comments.

native/user-profile/user-profile-relationship-button.react.js
45 ↗	(On Diff #31742)	When the viewer is viewing their own profile they should not see a relationship button so we should enter this condition here

Harbormaster completed remote builds in B23053: Diff 31742.Oct 6 2023, 5:55 AM

ginsu requested review of this revision.Oct 6 2023, 5:55 AM

atul accepted this revision.Oct 9 2023, 1:46 PM

This revision is now accepted and ready to land.Oct 9 2023, 1:46 PM

rebase before landing

Harbormaster completed remote builds in B23169: Diff 31900.Oct 11 2023, 2:33 AM

Closed by commit rCOMM6794479a1d26: [native] fix viewer user profile bototm sheet snap point (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM6794479a1d26: [native] fix viewer user profile bototm sheet snap point.

ashoat added inline comments.Oct 16 2023, 6:57 AM

native/user-profile/user-profile-relationship-button.react.js
63	Nit: this doesn't need to be in the dep list anymore

Revision Contents
Changeset List

Path

Size

native/

user-profile/

user-profile-relationship-button.react.js

6 lines

Diff 31913

View Options

native/user-profile/user-profile-relationship-button.react.js

[native] fix viewer user profile bototm sheet snap pointClosedPublicActions