web] introduce createMemberMapForUserMentions function
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:44 AM.

Details

Reviewers

atul
inka

Commits

rCOMM36d3f5cf75cb: [lib/native/web] introduce createMemberMapForUserMentions function

Summary

This mini stack right here will deal with making the @mention of a user a touchable that will navigate to the user profile whenever onPress is called.

This is step 1 in the list below
Outlined below are the steps I will take to make @metion of a user into a touchable

Introduce createMemberMapForUserMentions function (Right now we only store a set of usernames but we also will want to know the id of the user based on the username)
Introduce parseUserMentions function (We will use this function to get and return a userID from the membersMap)
Introduce userProfileBottomSheetActive state to the markdown context (This will be used for disabling the press to focus on a message functionality)
Introduce MarkdownUserMention component (this will render the touchable that will navigate to the user profile)

Depends on D9390

Test Plan

flow and confirmed that there were no regressions with @mention of a user

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 6 2023, 4:44 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:44 AM

ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 4:55 AM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9390: [native] make user profile accessible from MessageReactionsModal.

Harbormaster completed remote builds in B23049: Diff 31738.Oct 6 2023, 5:02 AM

ginsu requested review of this revision.Oct 6 2023, 5:02 AM

ginsu added a child revision: D9392: [lib/native] introduce parseUserMentions function.Oct 6 2023, 5:02 AM

atul accepted this revision.Oct 9 2023, 1:26 PM

atul added inline comments.

lib/shared/markdown.js
203–210 ↗	(On Diff #31738)	Could also do something like const filteredMembers = members .filter(member => member.role && member.username) .map(member => [member.username.toLowerCase(), member.id]); return new Map<string, string>(filteredMembers); which imo is a bit easier to read + less indentation, but up to you