Page MenuHomePhabricator
Differential D9388

[native] make user profile accessible from ThreadSettingsMember
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 1:21 PM
Unknown Object (File)
Apr 18 2024, 7:09 AM
Unknown Object (File)
Apr 18 2024, 7:09 AM
Unknown Object (File)
Apr 18 2024, 7:09 AM
Unknown Object (File)
Apr 18 2024, 7:08 AM
Unknown Object (File)
Apr 18 2024, 7:03 AM
Unknown Object (File)
Mar 4 2024, 12:02 PM
Unknown Object (File)
Mar 4 2024, 12:02 PM
View All 22 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMc4b6f6641f81: [native] make user profile accessible from ThreadSettingsMember
Summary

This diff makes ThreadSettingsMember into a touchable that will navigate to the user profile whenever onPress is triggered

Depends on D9387

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 6 2023, 4:07 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:07 AM
ginsu edited the test plan for this revision. (Show Details)Oct 6 2023, 4:10 AM
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F794275: Screen Recording 2023-10-06 at 7.10.02 AM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D9387: [native] simplify ThreadSettingsMember jsx.
Harbormaster completed remote builds in B23046: Diff 31735.Oct 6 2023, 4:24 AM
ginsu requested review of this revision.Oct 6 2023, 4:24 AM
ginsu added a child revision: D9389: [lib/native/web] make user profile accessible from a user entity in a robotext.Oct 6 2023, 4:25 AM
atul accepted this revision.Oct 9 2023, 12:49 PM
atul added inline comments.
native/chat/settings/thread-settings-member.react.js
284–294 ↗(On Diff #31735)

Wouldn't hurt to memoize this?

This revision is now accepted and ready to land.Oct 9 2023, 12:49 PM
ginsu added inline comments.Oct 9 2023, 2:00 PM
native/chat/settings/thread-settings-member.react.js
284–294 ↗(On Diff #31735)

Is this component not already memoized on line 256?

atul added inline comments.Oct 9 2023, 2:06 PM
native/chat/settings/thread-settings-member.react.js
284–294 ↗(On Diff #31735)

Ah yeah true

ginsu updated this revision to Diff 31893.Oct 11 2023, 1:34 AM

rebase before landing

Harbormaster completed remote builds in B23162: Diff 31893.Oct 11 2023, 1:54 AM
Closed by commit rCOMMc4b6f6641f81: [native] make user profile accessible from ThreadSettingsMember (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc4b6f6641f81: [native] make user profile accessible from ThreadSettingsMember.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
17 lines

Diff 31907

View Options

native/chat/settings/thread-settings-member.react.js

Loading...