[native] make user profile accessible from MessageReactionsModal
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 11:28 AM.

Details

Reviewers

atul
inka

Commits

rCOMM8ddf0f4df65a: [native] make user profile accessible from MessageReactionsModal

Summary

This diff makes the renderItem inside of MessageReactionsModal into a touchable that will navigate to the user profile whenever onPress is triggered

Depends on D9389

Test Plan

Please see the demo video below:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 6 2023, 11:28 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 11:28 AM

ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 11:32 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9389: [lib/native/web] make user profile accessible from a user entity in a robotext.

ginsu attached a referenced file: F794352: Screen Recording 2023-10-06 at 7.31.21 AM.mov. (Show Details)

ginsu added inline comments.Oct 6 2023, 11:39 AM

native/chat/message-reactions-modal.react.js
51–58 ↗	(On Diff #31737)	I created this `useEffect` that will call the `navigateToUserProfileBottomSheet` callback whenever the `MessageReactionsModal` is unmounting and there is a `selectedUserID`. This will make sure that the user profile bottom sheet slides in only after the `MessageReactionsModal` has finished sliding out.

Harbormaster completed remote builds in B23048: Diff 31737.Oct 6 2023, 11:45 AM

ginsu requested review of this revision.Oct 6 2023, 11:45 AM

ginsu added a child revision: D9391: [lib/native/web] introduce createMemberMapForUserMentions function.Oct 6 2023, 11:55 AM

atul accepted this revision.Oct 9 2023, 8:19 PM

atul added inline comments.

native/chat/message-reactions-modal.react.js
51–58 ↗	(On Diff #31737)	Hm, it seems like a clever solution but isn't super intuitive without this annotation.... at a minimum could you add a comment above the `useEffect` explaining what's going on? I'm guessing you discussed with eg Ted that we don't want the `UserProfileBottomSheet` appearing over the reactions modal? Just brainstorming... Could we have some `bottomSheetPresented` state "above" this component that gets set/unset as part of the `useEffect`? Could be consumed in a separate `useEffect` to `navigateToUserProfileBottomSheet`? Similar to `ModalProvider` on `web` could we have some higher level abstraction that handles "stacks" of `BottomSheet`s? Might be overkill but may allow for simpler API

This revision is now accepted and ready to land.Oct 9 2023, 8:19 PM

atul added inline comments.Oct 9 2023, 8:20 PM

native/chat/message-reactions-modal.react.js
51–58 ↗	(On Diff #31737)	Might be overkill but may allow for simpler API (eg `presentSheet(...)`) that handles fading in/out/etc

ginsu added inline comments.Oct 11 2023, 8:41 AM

native/chat/message-reactions-modal.react.js
51–58 ↗	(On Diff #31737)	Hm, it seems like a clever solution but isn't super intuitive without this annotation.... at a minimum could you add a comment above the useEffect explaining what's going on? Yea definitely > I'm guessing you discussed with eg Ted that we don't want the UserProfileBottomSheet appearing over the reactions modal? Here is what is on the Figma Might be overkill but may allow for simpler API (eg presentSheet(...)) that handles fading in/out/etc Agree that this API could be improved. Will create a Linear task to track for the time being