Page MenuHomePhabricator
Differential D9386

[native] make user profile accessible from message author name
ClosedPublic
Actions

Authored by ginsu on Oct 6 2023, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 5:50 AM
Unknown Object (File)
Sun, Mar 16, 9:32 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:51 PM
Unknown Object (File)
Thu, Mar 13, 4:45 PM
Unknown Object (File)
Sat, Mar 8, 9:56 AM
View All 99 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMcaacb9fa5c95: [native] make user profile accessible from message author name
Summary

This diff makes the user username in the message thread a touchable that will navigate to the user profile whenever onPress is triggered

Depends on D9385

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 6 2023, 4:00 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 6 2023, 4:00 AM
ginsu edited the summary of this revision. (Show Details)Oct 6 2023, 4:02 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9385: [native] utilize memoization in the MesssageHeader component.
ginsu attached a referenced file: F794211: Screen Recording 2023-10-06 at 7.01.13 AM.mov. (Show Details)
ginsu added a child revision: D9387: [native] simplify ThreadSettingsMember jsx.Oct 6 2023, 4:05 AM
Harbormaster completed remote builds in B23044: Diff 31733.Oct 6 2023, 4:17 AM
ginsu requested review of this revision.Oct 6 2023, 4:17 AM
atul accepted this revision.Oct 6 2023, 1:29 PM
This revision is now accepted and ready to land.Oct 6 2023, 1:29 PM
ginsu updated this revision to Diff 31891.Oct 11 2023, 1:33 AM

rebase before landing

Harbormaster completed remote builds in B23160: Diff 31891.Oct 11 2023, 1:50 AM
Closed by commit rCOMMcaacb9fa5c95: [native] make user profile accessible from message author name (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMcaacb9fa5c95: [native] make user profile accessible from message author name.

Revision Contents
Changeset List

PathSize
native/
chat/
20 lines

Diff 31905

View Options

native/chat/message-header.react.js

Show All 18 Linesimport {
register, register,
getOlmSessionInitializationDataActionTypes, getOlmSessionInitializationDataActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { validUsernameRegex } from 'lib/shared/account-utils.js'; import { validUsernameRegex } from 'lib/shared/account-utils.js';
import { useInitialNotificationsEncryptedMessage } from 'lib/shared/crypto-utils.js';
import type { import type {
RegisterInfo, RegisterInfo,
LogInExtraInfo, LogInExtraInfo,
RegisterResult, RegisterResult,
LogInStartingPayload, LogInStartingPayload,
} from 'lib/types/account-types.js'; } from 'lib/types/account-types.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
type DispatchActionPromise, type DispatchActionPromise,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { NavContext } from '../navigation/navigation-context.js'; import { NavContext } from '../navigation/navigation-context.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js'; import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { useInitialNotificationsEncryptedMessage } from '../utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
export type RegisterState = { export type RegisterState = {
+usernameInputText: string, +usernameInputText: string,
+passwordInputText: string, +passwordInputText: string,
+confirmPasswordInputText: string, +confirmPasswordInputText: string,
}; };
type BaseProps = { type BaseProps = {
▲ Show 20 Lines • Show All 424 Lines • ▼ Show 20 Lines const logInExtraInfo = useSelector(state =>
navContext, navContext,
}), }),
); );
const dispatch = useDispatch(); const dispatch = useDispatch();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callRegister = useServerCall(register); const callRegister = useServerCall(register);
const getInitialNotificationsEncryptedMessage = const getInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage(); useInitialNotificationsEncryptedMessage(
nativeNotificationsSessionCreator,
);
return ( return (
<RegisterPanel <RegisterPanel
{...props} {...props}
loadingStatus={loadingStatus} loadingStatus={loadingStatus}
logInExtraInfo={logInExtraInfo} logInExtraInfo={logInExtraInfo}
dispatch={dispatch} dispatch={dispatch}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
Show All 9 Lines