Page MenuHomePhabricator
Differential D9289

[native] make user profile accessible from message author avatar
ClosedPublic
Actions

Authored by ginsu on Sep 25 2023, 7:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:16 PM
Unknown Object (File)
Sun, Mar 16, 10:00 PM
Unknown Object (File)
Sun, Mar 16, 10:00 PM
Unknown Object (File)
Sun, Mar 16, 10:00 PM
Unknown Object (File)
Sun, Mar 16, 9:59 PM
Unknown Object (File)
Sun, Mar 16, 9:32 PM
Unknown Object (File)
Mon, Mar 3, 12:56 PM
Unknown Object (File)
Feb 24 2025, 12:22 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM6e296d4e4291: [native] make user profile accessible from message author avatar
Summary

This diff makes the user avatar in the message thread a TouchableOpacity that will navigate to the user profile whenever onPress is triggered

Depends on D9286

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 25 2023, 7:21 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 25 2023, 7:21 AM
ginsu edited the summary of this revision. (Show Details)Sep 25 2023, 7:23 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9286: [native] make user profiles accessible from RelationshipListItem.
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F773465: Screen Recording 2023-09-25 at 10.23.52 AM.mov. (Show Details)
Harbormaster completed remote builds in B22832: Diff 31403.Sep 25 2023, 7:38 AM
ginsu requested review of this revision.Sep 25 2023, 7:38 AM
atul accepted this revision.Sep 26 2023, 2:12 PM

Looks good!

This revision is now accepted and ready to land.Sep 26 2023, 2:12 PM
ginsu added a child revision: D9385: [native] utilize memoization in the MesssageHeader component.Oct 6 2023, 3:58 AM
ginsu updated this revision to Diff 31889.Oct 11 2023, 1:31 AM

rebase before landing

Harbormaster completed remote builds in B23158: Diff 31889.Oct 11 2023, 1:49 AM
Closed by commit rCOMM6e296d4e4291: [native] make user profile accessible from message author avatar (authored by ginsu). · Explain WhyOct 11 2023, 2:39 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6e296d4e4291: [native] make user profile accessible from message author avatar.

Revision Contents
Changeset List

PathSize
native/
chat/
28 lines

Diff 31903

View Options

native/chat/composed-message.react.js

Show All 27 Lines
import createIDs from './id-creator.js'; import createIDs from './id-creator.js';
import createMessages from './message-creator.js'; import createMessages from './message-creator.js';
import { import {
createInitialRolesForNewThread, createInitialRolesForNewThread,
getRolePermissionBlobs, getRolePermissionBlobs,
} from './role-creator.js'; } from './role-creator.js';
import type { UpdatesForCurrentSession } from './update-creator.js'; import type { UpdatesForCurrentSession } from './update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js'; import {
fetchLatestEditMessageContentByID,
fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';
import { import {
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
} from '../fetchers/thread-fetchers.js'; } from '../fetchers/thread-fetchers.js';
import { import {
checkThreadPermission, checkThreadPermission,
validateCandidateMembers, validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js'; } from '../fetchers/thread-permission-fetchers.js';
▲ Show 20 Lines • Show All 371 Lines • ▼ Show 20 Lines messageDatas.push({
}, },
}); });
} else { } else {
invariant(parentThreadID, 'parentThreadID should be set for sidebar'); invariant(parentThreadID, 'parentThreadID should be set for sidebar');
if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) { if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
let editedSourceMessage = sourceMessage;
if (sourceMessageID && sourceMessage.type === messageTypes.TEXT) {
const editMessageContent = await fetchLatestEditMessageContentByID(
sourceMessageID,
);
if (editMessageContent) {
editedSourceMessage = {
...sourceMessage,
text: editMessageContent.text,
};
}
}
messageDatas.push( messageDatas.push(
{ {
type: messageTypes.SIDEBAR_SOURCE, type: messageTypes.SIDEBAR_SOURCE,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessage, sourceMessage: editedSourceMessage,
}, },
{ {
type: messageTypes.CREATE_SIDEBAR, type: messageTypes.CREATE_SIDEBAR,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessageAuthorID: sourceMessage.creatorID, sourceMessageAuthorID: sourceMessage.creatorID,
initialThreadState: { initialThreadState: {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines