Page MenuHomePhabricator
Differential D9481

[web] make user profile accessible from message author avatar + name
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 5, 12:27 PM
Unknown Object (File)
Fri, Jul 5, 9:29 AM
Unknown Object (File)
Fri, Jul 5, 8:47 AM
Unknown Object (File)
Thu, Jul 4, 10:56 AM
Unknown Object (File)
Thu, Jul 4, 10:17 AM
Unknown Object (File)
Thu, Jul 4, 9:36 AM
Unknown Object (File)
Thu, Jul 4, 6:38 AM
Unknown Object (File)
Sat, Jun 29, 7:21 PM
View All 60 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMc057d42b4f7b: [web] make user profile accessible from message author avatar + name
Summary

This diff makes the message author avatar + name interactive. When a user clicks on this component, the user profile modal will be pushed

Linear Task:
https://linear.app/comm/issue/ENG-5240/make-user-profile-accessible-from-message-author-avatar
https://linear.app/comm/issue/ENG-5241/make-user-profile-accessible-from-message-author-name

Depends on D9477

Test Plan

Pleas see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 12 2023, 10:38 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 10:38 PM
ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 10:40 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9477: [web] make user profile accessible from friend/block list row.
ginsu attached a referenced file: F811904: Screen Recording 2023-10-13 at 1.39.36 AM.mov. (Show Details)
Harbormaster completed remote builds in B23231: Diff 31987.Oct 12 2023, 10:54 PM
ginsu requested review of this revision.Oct 12 2023, 10:54 PM
ginsu added a child revision: D9483: [web] make user profile accessible from member component.Oct 12 2023, 11:00 PM
atul accepted this revision.Oct 16 2023, 11:50 AM
This revision is now accepted and ready to land.Oct 16 2023, 11:50 AM
ginsu mentioned this in D9506: [web] update usePushUserProfileModal hook args.Oct 16 2023, 10:53 PM
ginsu updated this revision to Diff 32092.Oct 17 2023, 11:32 AM

rebase before landing

ginsu updated this revision to Diff 32096.Oct 17 2023, 11:51 AM

rebase

Harbormaster completed remote builds in B23297: Diff 32092.Oct 17 2023, 11:52 AM
Harbormaster completed remote builds in B23301: Diff 32096.Oct 17 2023, 12:11 PM
ginsu updated this revision to Diff 32105.Oct 17 2023, 1:05 PM

update before landing

Harbormaster completed remote builds in B23310: Diff 32105.Oct 17 2023, 1:24 PM
Closed by commit rCOMMc057d42b4f7b: [web] make user profile accessible from message author avatar + name (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc057d42b4f7b: [web] make user profile accessible from message author avatar + name.

Revision Contents
Changeset List

PathSize
web/
chat/
11 lines
13 lines

Diff 32092

View Options

web/chat/chat-message-list.css

Loading...
View Options

web/chat/composed-message.react.js

Loading...