resolveInvalidatedCookie used to call boundCallServerEndpoint defined right above. Now, that login action takes CallKeyserverEndpoint instead of CallServerEndpoint, we need to create a CallKeyserverEndpoint function and pass it to resolveInvalidatedCookie which calls login. But here, we are in the context of one keyserver (this function is called for one, specific keyserver) , so this CallKeyserverEndpoint is just a wrapper to be able to use the login action underneath. For reference see callKeyserverEndpoint in keyserver-call.js in D9217
Calling only one keyserver with login action may seem odd, but this actually makes sense, because one keyserver may return a session change, triggering the call to fetchNewCookieFromNativeCredentials which calls login underneath.

In this case, we know which keyserver we want to be called, so we pass it into the action to avoid unnecessary calls to identity service.

Why are we passing both of these in? Is the idea that we will have both of them going forward? Or are you going to remove boundCallServerEndpoint in a subsequent diff?

Will this get updated in a subsequent diff? Is there a task tracking it?

boundCallServerEndpoint is passed in resolveInvalidatedCookie to getInitialNotificationsEncryptedMessage. In the codebase today the only used getInitialNotificationsEncryptedMessage is the function returned from useInitialNotificationsEncryptedMessage. This function uses callServerEndpoint to call getOlmSessionInitializationData action, that indeed takes CallServerEndpoint - it wasn't refactored as discussed here
Eventually boundCallServerEndpoint should be removed, once getOlmSessionInitializationData is refactored to call the identity service

Since getOlmSessionInitializationData will be refactored as part of the identity service work, this will have to be refactored as a result (since the only reason for passing here callServerEndpoint is that it is being passed down to getOlmSessionInitializationData action)
@varun do you need me to create any tasks for this, or is will this follow naturally from your other changes?

Please link a task before landing

would you mind creating a task under this parent? https://linear.app/comm/issue/ENG-3262/new-keyserver-endpoint-for-logging-in-using-identity-service-based

will probably get covered in my work but i don't want to miss it by mistake

Here is the task: ENG-5658

Can we change this Object?