Allows for packaging of the grpc generated files, this allows for
downstream packages such as tunnelbroker to then find_package(comm-grpc)
and use the related targets and avoids needing to interact with
code generation logic.
Depends on D4294
Paths
| Differential D3867 Authored by • jon on Apr 27 2022, 5:00 PM.
Tags None Referenced Files
Details Summary Allows for packaging of the grpc generated files, this allows for Depends on D4294 Test Plan nix build .#comm-grpc Then inspect ./result
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Harbormaster failed remote builds in B9817: Diff 13581!Jun 19 2022, 3:50 PM2022-06-19 15:50:39 (UTC-7) Comment Actions Restore NativeModules.{h,cpp} Their generation is a bit more involved with react-native Harbormaster failed remote builds in B9820: Diff 13584!Jun 19 2022, 4:02 PM2022-06-19 16:02:17 (UTC-7) This revision is now accepted and ready to land.Jun 21 2022, 8:18 PM2022-06-21 20:18:16 (UTC-7) Herald added a reviewer: ashoat. · View Herald TranscriptJun 21 2022, 8:18 PM2022-06-21 20:18:16 (UTC-7) This revision now requires review to proceed.Jun 21 2022, 8:18 PM2022-06-21 20:18:16 (UTC-7) ashoat added inline comments.
This revision is now accepted and ready to land.Jun 22 2022, 10:48 AM2022-06-22 10:48:40 (UTC-7) Comment Actions comments addressed
Harbormaster failed remote builds in B9904: Diff 13696!Jun 22 2022, 7:54 PM2022-06-22 19:54:27 (UTC-7) Harbormaster failed remote builds in B9906: Diff 13698!Jun 22 2022, 8:24 PM2022-06-22 20:24:12 (UTC-7) This revision now requires review to proceed.Jun 27 2022, 9:20 AM2022-06-27 09:20:17 (UTC-7)
• max added inline comments.
This revision is now accepted and ready to land.Jun 30 2022, 8:24 AM2022-06-30 08:24:55 (UTC-7) Comment Actions Since I "backported" some of the header changes, these changes will no longer work in isolation Harbormaster failed remote builds in B10219: Diff 14106!Jul 3 2022, 9:10 AM2022-07-03 09:10:17 (UTC-7) • jon marked an inline comment as done. Comment ActionsSince I did a pretty fundamental change, please re-review Comment Actions Repeating feedback I have left before. Please consider the meta-feedback I left in D4297... if you integrate feedback after the first time it's given to you, we can significantly reduce the number of cycles of review your diffs have to go through, and save both you and your reviewers some time
This revision now requires changes to proceed.Jul 3 2022, 11:53 AM2022-07-03 11:53:32 (UTC-7) Harbormaster failed remote builds in B10323: Diff 14230!Jul 6 2022, 10:49 AM2022-07-06 10:49:24 (UTC-7) This revision is now accepted and ready to land.Jul 6 2022, 12:49 PM2022-07-06 12:49:22 (UTC-7) Harbormaster failed remote builds in B10426: Diff 14370!Jul 8 2022, 9:40 PM2022-07-08 21:40:01 (UTC-7) Harbormaster failed remote builds in B10657: Diff 14668!Jul 19 2022, 5:38 PM2022-07-19 17:38:47 (UTC-7) Harbormaster failed remote builds in B10837: Diff 14900!Jul 25 2022, 8:54 PM2022-07-25 20:54:07 (UTC-7) • jon added a parent revision: D4604: [Nix] Add support for tunnelbroker build.Jul 25 2022, 9:11 PM2022-07-25 21:11:06 (UTC-7) • jon removed parent revisions: D4294: [nix] Add dependencies needed to compile native modules, D3865: Add protobuf with corrected cmake build. Harbormaster failed remote builds in B10845: Diff 14908!Jul 25 2022, 9:17 PM2022-07-25 21:17:57 (UTC-7) Harbormaster failed remote builds in B10846: Diff 14909!Jul 25 2022, 9:20 PM2022-07-25 21:20:51 (UTC-7) Harbormaster failed remote builds in B10847: Diff 14910!Jul 25 2022, 9:22 PM2022-07-25 21:22:54 (UTC-7) Harbormaster failed remote builds in B10848: Diff 14911!Jul 25 2022, 9:24 PM2022-07-25 21:24:45 (UTC-7) Harbormaster failed remote builds in B10849: Diff 14912!Jul 25 2022, 9:33 PM2022-07-25 21:33:29 (UTC-7) • jon removed a parent revision: D4294: [nix] Add dependencies needed to compile native modules.Jul 26 2022, 8:19 AM2022-07-26 08:19:24 (UTC-7) Harbormaster completed remote builds in B10918: Diff 15023.Jul 27 2022, 12:13 PM2022-07-27 12:13:10 (UTC-7) Closed by commit rCOMMeba6b9ff51ae: [services] Export comm's grpc generated files as cmake project (authored by • jon). · Explain WhyJul 28 2022, 5:41 PM2022-07-28 17:41:58 (UTC-7) This revision was automatically updated to reflect the committed changes. • jon added a child revision: D4295: [services] Export cpp tools as CMake project.Aug 10 2022, 4:55 PM2022-08-10 16:55:24 (UTC-7) • jon removed a child revision: D4295: [services] Export cpp tools as CMake project.Aug 12 2022, 4:14 PM2022-08-12 16:14:13 (UTC-7)
Revision Contents
Diff 13696 native/cpp/CommonCpp/grpc/CMakeLists.txt
native/cpp/CommonCpp/grpc/Client.h
native/cpp/CommonCpp/grpc/Client.cpp
native/cpp/CommonCpp/grpc/ClientGetReadReactor.h
|
If we already display threads/reactions container, the height is not changed.