Paths

Table of Contentst

Differential D6336

[web] Remove LeftLayoutAside
ClosedPublic
Actions

Authored by inka on Jan 22 2023, 11:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 2:57 AM

	Unknown Object (File)
	Thu, Nov 7, 3:21 PM

	Unknown Object (File)
	Tue, Oct 29, 4:49 AM

	Unknown Object (File)
	Mon, Oct 28, 8:11 AM

	Unknown Object (File)
	Sun, Oct 20, 9:38 PM

	Unknown Object (File)
	Sun, Oct 20, 5:19 AM

	Unknown Object (File)
	Oct 13 2024, 5:25 AM

	Unknown Object (File)
	Oct 11 2024, 4:58 PM

Subscribers

Details

Reviewers

• przemek
michal
bartek
tomek

Commits

rCOMM392d1c189563: [web] Remove LeftLayoutAside

Summary

Since D6344 the LeftLayoutAside is obsolete. I'm removing it, and putting the CommunityPicker directly in the App component.
This also calls for removing the left-layout-aside.css, which I'll do in the next diff, as it requires some code to be moved somewhere else.

Test Plan

Run the web app, check that the sidebar displayes correctly.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 22 2023, 11:05 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 22 2023, 11:05 AM

Remove unused styles

inka added a parent revision: D6335: [web] Move navigation panel from the sidebar to a topbar.Jan 22 2023, 11:06 AM

Harbormaster completed remote builds in B15521: Diff 21170.Jan 22 2023, 11:19 AM

Harbormaster completed remote builds in B15522: Diff 21171.

inka requested review of this revision.Jan 22 2023, 11:19 AM

inka mentioned this in D6337: [web] Move topbar related code out of web/sidebar.Jan 22 2023, 11:22 AM

inka added a child revision: D6337: [web] Move topbar related code out of web/sidebar.Jan 22 2023, 11:23 AM

inka planned changes to this revision.Jan 23 2023, 5:58 AM

Cherrypick

inka edited parent revisions, added: D6346: [web] Use SettingsSwitcher and Topbar; removed: D6335: [web] Move navigation panel from the sidebar to a topbar.Jan 23 2023, 10:24 AM

Harbormaster failed remote builds in B15553: Diff 21214!Jan 23 2023, 10:32 AM

inka added a child revision: D6338: [web] Add ID selector to search bar, to avoid weird hot reload side effects.Jan 23 2023, 10:36 AM

inka edited the summary of this revision. (Show Details)Jan 24 2023, 12:41 AM

Harbormaster completed remote builds in B15553: Diff 21214.Jan 24 2023, 12:51 AM

bartek accepted this revision.Jan 26 2023, 6:14 AM

This revision is now accepted and ready to land.Jan 26 2023, 6:14 AM

inka added a reviewer: tomek.Jan 27 2023, 2:13 AM

This revision now requires review to proceed.Jan 27 2023, 2:13 AM

inka edited the summary of this revision. (Show Details)Jan 31 2023, 4:19 AM

tomek accepted this revision.Jan 31 2023, 7:20 AM

tomek added inline comments.

web/sidebar/left-layout-aside.css
8–34 ↗	(On Diff #21214)	Can we rename the file?

This revision is now accepted and ready to land.Jan 31 2023, 7:20 AM

inka added inline comments.Jan 31 2023, 8:13 AM

web/sidebar/left-layout-aside.css
8–34 ↗	(On Diff #21214)	As mentioned in the summary, this requires some code to be moved around, so it's done in a separate diff D6361

Rebase

Harbormaster failed remote builds in B16413: Diff 22450!Feb 13 2023, 7:31 AM

Rebase

Harbormaster completed remote builds in B16491: Diff 22538.Feb 14 2023, 3:28 AM

Closed by commit rCOMM392d1c189563: [web] Remove LeftLayoutAside (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM392d1c189563: [web] Remove LeftLayoutAside.

Revision Contents
Changeset List

Path

Size

web/

6 lines

sidebar/

left-layout-aside.css

7 lines

left-layout-aside.react.js

4 lines

Diff 22450

web/app.react.js

Loading...

web/sidebar/left-layout-aside.css

Loading...

web/sidebar/left-layout-aside.react.js

Loading...

web/style.css

Loading...