Page MenuHomePhabricator
Differential D7128

[lib][keyserver] Added new edit_message endpoint
ClosedPublic
Actions

Authored by • kuba on Mar 21 2023, 11:30 AM.
Tags
None
Referenced Files
F3524399: D7128.diff
Mon, Dec 23, 12:35 PM
Unknown Object (File)
Thu, Dec 5, 7:47 AM
Unknown Object (File)
Thu, Dec 5, 7:47 AM
Unknown Object (File)
Thu, Dec 5, 7:46 AM
Unknown Object (File)
Thu, Dec 5, 7:46 AM
Unknown Object (File)
Nov 10 2024, 4:22 PM
Unknown Object (File)
Nov 10 2024, 12:19 PM
Unknown Object (File)
Nov 10 2024, 10:16 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
Commits
rCOMM8e98df9d151f: [lib][keyserver] Added new edit_message endpoint
Summary

Added new editMessageResponder with validation. Registered it as an endpoint.

Test Plan

In later diffs checked if it is possible to communicate with the keyserver. For now, checked if there are no flow errors and if the app is working correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Mar 21 2023, 11:30 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 21 2023, 11:30 AM
• kuba added a parent revision: D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.Mar 21 2023, 11:30 AM
• kuba added a child revision: D7129: [lib] Added new 'sendEditMessage' action.Mar 21 2023, 11:37 AM
Harbormaster completed remote builds in B17487: Diff 23955.Mar 21 2023, 11:45 AM
• kuba requested review of this revision.Mar 21 2023, 11:45 AM
• kuba updated this revision to Diff 23977.Mar 22 2023, 4:51 AM

Simplified text variable

Harbormaster completed remote builds in B17509: Diff 23977.Mar 22 2023, 5:06 AM
inka added a comment.Mar 28 2023, 8:03 AM

I think you test plan got cut off

keyserver/src/responders/message-responders.js
339–350 ↗(On Diff #23977)

Can we simplify this?

• kuba added inline comments.Mar 28 2023, 8:49 AM
keyserver/src/responders/message-responders.js
339–350 ↗(On Diff #23977)

Sure, I could do that here, but the array is still needed in a later diff: https://phab.comm.dev/D7145

inka added a comment.EditedMar 29 2023, 1:12 AM

What about the test plan?

keyserver/src/responders/message-responders.js
339–350 ↗(On Diff #23977)

Alright, no need then

• kuba edited the test plan for this revision. (Show Details)Mar 29 2023, 2:10 AM
In D7128#214943, @inka wrote:

What about the test plan?

Sorry, I haven't seen the comment. I've just completed the test plan.

michal accepted this revision.Mar 30 2023, 2:54 AM

Looks good to me

This revision is now accepted and ready to land.Mar 30 2023, 2:54 AM
Closed by commit rCOMM8e98df9d151f: [lib][keyserver] Added new edit_message endpoint (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMar 30 2023, 7:43 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM8e98df9d151f: [lib][keyserver] Added new edit_message endpoint.

Revision Contents
Changeset List

PathSize
keyserver/
src/
5 lines
responders/
67 lines
lib/
types/
1 line
9 lines

Diff 23955

View Options

keyserver/src/endpoints.js

Loading...
View Options

keyserver/src/responders/message-responders.js

Loading...
View Options

lib/types/endpoints.js

Loading...
View Options

lib/types/message-types.js

Loading...