Page MenuHomePhabricator
Differential D7145

[keyserver] Adding edit_message to the sidebar thread
ClosedPublic
Actions

Authored by • kuba on Mar 22 2023, 6:24 AM.
Tags
None
Referenced Files
F3525846: D7145.id24064.diff
Mon, Dec 23, 6:32 PM
F3525550: D7145.id24474.diff
Mon, Dec 23, 5:38 PM
F3525514: D7145.id23993.diff
Mon, Dec 23, 5:26 PM
F3524358: D7145.diff
Mon, Dec 23, 12:24 PM
Unknown Object (File)
Sun, Dec 15, 2:45 PM
Unknown Object (File)
Sat, Dec 7, 11:38 PM
Unknown Object (File)
Sat, Dec 7, 11:38 PM
Unknown Object (File)
Thu, Dec 5, 1:57 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
ashoat
Commits
rCOMM4ccb27a3512b: [keyserver] Adding edit_message to the sidebar thread
Summary

This handles the situation, where the user edits a message which has a sidebar. It adds edit_message to the sidebar thread.

Test Plan

Called editing message endpoint for a message which has a sidebar. The edit message has been added to both the main thread and the sidebar thread. Reducer on client side properly
merges two new messages instead of one.

Diff Detail

Repository
rCOMM Comm
Branch
kuba/messageediting
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Mar 22 2023, 6:24 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 22 2023, 6:24 AM
• kuba added a parent revision: D7144: [lib] Added edit message action reducer.Mar 22 2023, 6:25 AM
Harbormaster completed remote builds in B17525: Diff 23993.Mar 22 2023, 6:39 AM
• kuba requested review of this revision.Mar 22 2023, 6:39 AM
ashoat accepted this revision.Mar 22 2023, 3:25 PM
ashoat added inline comments.
keyserver/src/responders/message-responders.js
344

Nit: this line should be grouped with where it's used, instead of with the creatorID check above

357

I don't think this comment is adding any value. I would remove it

This revision is now accepted and ready to land.Mar 22 2023, 3:25 PM
• kuba mentioned this in D7141: [keyserver] Display edited message in the sidebar if the source message is edited.Mar 23 2023, 8:43 AM
• kuba updated this revision to Diff 24064.Mar 24 2023, 3:56 AM
• kuba marked 2 inline comments as done.

Address comments

Harbormaster completed remote builds in B17576: Diff 24064.Mar 24 2023, 4:11 AM
• kuba mentioned this in D7128: [lib][keyserver] Added new edit_message endpoint.Mar 28 2023, 8:49 AM
Closed by commit rCOMM4ccb27a3512b: [keyserver] Adding edit_message to the sidebar thread (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMar 31 2023, 2:50 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM4ccb27a3512b: [keyserver] Adding edit_message to the sidebar thread.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
35 lines

Diff 23993

View Options

keyserver/src/responders/message-responders.js

Loading...