Page MenuHomePhabricator

[native] Handle entering edit mode when already in edit mode
ClosedPublic

Authored by kuba on Apr 19 2023, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 2:10 AM
Unknown Object (File)
Sat, Dec 7, 2:10 AM
Unknown Object (File)
Sat, Dec 7, 2:10 AM
Unknown Object (File)
Sat, Dec 7, 2:10 AM
Unknown Object (File)
Nov 8 2024, 5:05 PM
Unknown Object (File)
Nov 8 2024, 5:05 PM
Unknown Object (File)
Nov 8 2024, 5:05 PM
Unknown Object (File)
Nov 8 2024, 5:04 PM
Subscribers

Details

Summary

We want to prevent a user from losing edited changes when entering edit mode for another message. Added displaying confirmation alert. For now, it doesn't check if there are some changes, which can be added later.

Test Plan

Turned on the app on iOS. Entered edit mode. Checked if the edit button doesn't show anymore for the currently edited message. Tried to edit another message. The confirmation alert appeared.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Reverted some accidentally added changes

I think it would be better to indeed check if there are any changes, for consistency with exiting edit mode in other ways (D7349).
Can you either

  • do it in this diff
  • do it in another diff
  • create a task to do it

?

In D7520#223110, @inka wrote:

I think it would be better to indeed check if there are any changes, for consistency with exiting edit mode in other ways (D7349).
Can you either

  • do it in this diff
  • do it in another diff
  • create a task to do it

?

I created a task for it (https://linear.app/comm/issue/ENG-3724/[native]-check-if-there-are-any-changes-while-changing-edited-message) because it requires accessing the state of the ChatInputBar, which is not straightforward, and I have to focus on the web version.

This revision is now accepted and ready to land.Apr 20 2023, 6:33 AM