[identity] some nits
ClosedPublic
Actions

Authored by varun on Apr 24 2023, 1:51 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMMe6f7c4f4af56: [identity] some nits

Summary

small changes to satisfy cargo clippy

Depends on D7595

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Branch

identity (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 24 2023, 1:51 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 24 2023, 1:51 PM

Harbormaster completed remote builds in B18715: Diff 25628.Apr 24 2023, 2:21 PM

varun requested review of this revision.Apr 24 2023, 2:21 PM

• jon accepted this revision.Apr 24 2023, 3:23 PM

• jon added inline comments.

services/identity/src/config.rs
100	If we can borrow here, I think we should. Guess it doesn't really matter

This revision is now accepted and ready to land.Apr 24 2023, 3:23 PM

varun added inline comments.Apr 24 2023, 8:32 PM

services/identity/src/config.rs
100	contents is already a `&str` so the borrow is redundant, which clippy doesn't like

bartek accepted this revision.Apr 24 2023, 8:34 PM

Closed by commit rCOMMe6f7c4f4af56: [identity] some nits (authored by varun). · Explain WhyApr 24 2023, 8:34 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe6f7c4f4af56: [identity] some nits.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

config.rs

6 lines

Diff 25628

View Options

services/identity/src/config.rs

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines	/* Begin PBXBuildFile section */
CB4821AA27CFB153001AB7E1 /* Tools.mm in Sources / = {isa = PBXBuildFile; fileRef = 71CA4AEB262F236100835C89 / Tools.mm */; };		CB4821AA27CFB153001AB7E1 /* Tools.mm in Sources / = {isa = PBXBuildFile; fileRef = 71CA4AEB262F236100835C89 / Tools.mm */; };
CB4821AC27CFB17C001AB7E1 /* Session.cpp in Sources / = {isa = PBXBuildFile; fileRef = 71BF5B6F26B3FF0900EDE27D / Session.cpp */; };		CB4821AC27CFB17C001AB7E1 /* Session.cpp in Sources / = {isa = PBXBuildFile; fileRef = 71BF5B6F26B3FF0900EDE27D / Session.cpp */; };
CB4821AD27CFB17C001AB7E1 /* NetworkModule.cpp in Sources / = {isa = PBXBuildFile; fileRef = 726E5D732731A4790032361D / NetworkModule.cpp */; };		CB4821AD27CFB17C001AB7E1 /* NetworkModule.cpp in Sources / = {isa = PBXBuildFile; fileRef = 726E5D732731A4790032361D / NetworkModule.cpp */; };
CB4821AE27CFB187001AB7E1 /* Tools.cpp in Sources / = {isa = PBXBuildFile; fileRef = 71BF5B7326B401D300EDE27D / Tools.cpp */; };		CB4821AE27CFB187001AB7E1 /* Tools.cpp in Sources / = {isa = PBXBuildFile; fileRef = 71BF5B7326B401D300EDE27D / Tools.cpp */; };
CB4821AF27CFB19D001AB7E1 /* PlatformSpecificTools.mm in Sources / = {isa = PBXBuildFile; fileRef = 71762A74270D8AAE00F565ED / PlatformSpecificTools.mm */; };		CB4821AF27CFB19D001AB7E1 /* PlatformSpecificTools.mm in Sources / = {isa = PBXBuildFile; fileRef = 71762A74270D8AAE00F565ED / PlatformSpecificTools.mm */; };
CB4821B127CFB1FA001AB7E1 /* GlobalNetworkSingleton.cpp in Sources / = {isa = PBXBuildFile; fileRef = 726E5D762731A5E10032361D / GlobalNetworkSingleton.cpp */; };		CB4821B127CFB1FA001AB7E1 /* GlobalNetworkSingleton.cpp in Sources / = {isa = PBXBuildFile; fileRef = 726E5D762731A5E10032361D / GlobalNetworkSingleton.cpp */; };
CB4821B227CFB20E001AB7E1 /* SQLiteQueryExecutor.cpp in Sources / = {isa = PBXBuildFile; fileRef = 71BE84412636A944002849D2 / SQLiteQueryExecutor.cpp */; };		CB4821B227CFB20E001AB7E1 /* SQLiteQueryExecutor.cpp in Sources / = {isa = PBXBuildFile; fileRef = 71BE84412636A944002849D2 / SQLiteQueryExecutor.cpp */; };
CBF332CD28E302EE00E80062 /* GlobalDBSingleton.cpp in Sources / = {isa = PBXBuildFile; fileRef = CBF332CC28E302C600E80062 / GlobalDBSingleton.cpp */; };		CBF332CD28E302EE00E80062 /* GlobalDBSingleton.cpp in Sources / = {isa = PBXBuildFile; fileRef = CBF332CC28E302C600E80062 / GlobalDBSingleton.cpp */; };
		CBF332D028E3037000E80062 /* GlobalDBSingletonIOSProxy.mm in Sources / = {isa = PBXBuildFile; fileRef = CBF332CE28E3037000E80062 / GlobalDBSingletonIOSProxy.mm */; };
CBFE58292885852B003B94C9 /* ThreadOperations.cpp in Sources / = {isa = PBXBuildFile; fileRef = CBFE58282885852B003B94C9 / ThreadOperations.cpp */; };		CBFE58292885852B003B94C9 /* ThreadOperations.cpp in Sources / = {isa = PBXBuildFile; fileRef = CBFE58282885852B003B94C9 / ThreadOperations.cpp */; };
D7DB6E0F85B2DBE15B01EC21 /* libPods-Comm.a in Frameworks / = {isa = PBXBuildFile; fileRef = 994BEBDD4E4959F69CEA0BC3 / libPods-Comm.a */; };		D7DB6E0F85B2DBE15B01EC21 /* libPods-Comm.a in Frameworks / = {isa = PBXBuildFile; fileRef = 994BEBDD4E4959F69CEA0BC3 / libPods-Comm.a */; };
F02C296C528B51ADAB5AA19D /* libPods-NotificationService.a in Frameworks / = {isa = PBXBuildFile; fileRef = 3EE4DCB430B05EC9DE7D7B01 / libPods-NotificationService.a */; };		F02C296C528B51ADAB5AA19D /* libPods-NotificationService.a in Frameworks / = {isa = PBXBuildFile; fileRef = 3EE4DCB430B05EC9DE7D7B01 / libPods-NotificationService.a */; };
FC2DF95528BFCFE90017C4AF /* tunnelbroker.grpc.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95128BFCFE90017C4AF / tunnelbroker.grpc.pb.cc */; };		FC2DF95528BFCFE90017C4AF /* tunnelbroker.grpc.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95128BFCFE90017C4AF / tunnelbroker.grpc.pb.cc */; };
FC2DF95628BFCFE90017C4AF /* tunnelbroker.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95328BFCFE90017C4AF / tunnelbroker.pb.cc */; };		FC2DF95628BFCFE90017C4AF /* tunnelbroker.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95328BFCFE90017C4AF / tunnelbroker.pb.cc */; };
FC2DF95728BFD02A0017C4AF /* tunnelbroker.grpc.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95128BFCFE90017C4AF / tunnelbroker.grpc.pb.cc */; };		FC2DF95728BFD02A0017C4AF /* tunnelbroker.grpc.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95128BFCFE90017C4AF / tunnelbroker.grpc.pb.cc */; };
FC2DF95828BFD0350017C4AF /* tunnelbroker.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95328BFCFE90017C4AF / tunnelbroker.pb.cc */; };		FC2DF95828BFD0350017C4AF /* tunnelbroker.pb.cc in Sources / = {isa = PBXBuildFile; fileRef = FC2DF95328BFCFE90017C4AF / tunnelbroker.pb.cc */; };
/* End PBXBuildFile section */		/* End PBXBuildFile section */
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Lines	/* Begin PBXFileReference section */
CB38F2BB286C6C970010535C /* EditEntryMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = EditEntryMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/EditEntryMessageSpec.h; sourceTree = "<group>"; };		CB38F2BB286C6C970010535C /* EditEntryMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = EditEntryMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/EditEntryMessageSpec.h; sourceTree = "<group>"; };
CB38F2BC286C6C970010535C /* CreateSubThreadMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CreateSubThreadMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/CreateSubThreadMessageSpec.h; sourceTree = "<group>"; };		CB38F2BC286C6C970010535C /* CreateSubThreadMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CreateSubThreadMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/CreateSubThreadMessageSpec.h; sourceTree = "<group>"; };
CB38F2BD286C6C970010535C /* MultimediaMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MultimediaMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MultimediaMessageSpec.h; sourceTree = "<group>"; };		CB38F2BD286C6C970010535C /* MultimediaMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MultimediaMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MultimediaMessageSpec.h; sourceTree = "<group>"; };
CB38F2BE286C6C980010535C /* DeleteEntryMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DeleteEntryMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/DeleteEntryMessageSpec.h; sourceTree = "<group>"; };		CB38F2BE286C6C980010535C /* DeleteEntryMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DeleteEntryMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/DeleteEntryMessageSpec.h; sourceTree = "<group>"; };
CB38F2BF286C6C980010535C /* UpdateRelationshipMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = UpdateRelationshipMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/UpdateRelationshipMessageSpec.h; sourceTree = "<group>"; };		CB38F2BF286C6C980010535C /* UpdateRelationshipMessageSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = UpdateRelationshipMessageSpec.h; path = PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/UpdateRelationshipMessageSpec.h; sourceTree = "<group>"; };
CB3C621327CE66540054F24C /* libEXSecureStore.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; path = libEXSecureStore.a; sourceTree = BUILT_PRODUCTS_DIR; };		CB3C621327CE66540054F24C /* libEXSecureStore.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; path = libEXSecureStore.a; sourceTree = BUILT_PRODUCTS_DIR; };
CBF332CB28E302C600E80062 /* GlobalDBSingleton.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GlobalDBSingleton.h; sourceTree = "<group>"; };		CBF332CB28E302C600E80062 /* GlobalDBSingleton.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GlobalDBSingleton.h; sourceTree = "<group>"; };
CBF332CC28E302C600E80062 /* GlobalDBSingleton.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = GlobalDBSingleton.cpp; sourceTree = "<group>"; };		CBF332CC28E302C600E80062 /* GlobalDBSingleton.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = GlobalDBSingleton.cpp; sourceTree = "<group>"; };
		CBF332CE28E3037000E80062 /* GlobalDBSingletonIOSProxy.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = GlobalDBSingletonIOSProxy.mm; path = Comm/GlobalDBSingletonIOSProxy.mm; sourceTree = "<group>"; };
		CBF332CF28E3037000E80062 /* GlobalDBSingletonIOSProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = GlobalDBSingletonIOSProxy.h; path = Comm/GlobalDBSingletonIOSProxy.h; sourceTree = "<group>"; };
CBFE58272885852B003B94C9 /* ThreadOperations.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ThreadOperations.h; path = PersistentStorageUtilities/ThreadOperationsUtilities/ThreadOperations.h; sourceTree = "<group>"; };		CBFE58272885852B003B94C9 /* ThreadOperations.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ThreadOperations.h; path = PersistentStorageUtilities/ThreadOperationsUtilities/ThreadOperations.h; sourceTree = "<group>"; };
CBFE58282885852B003B94C9 /* ThreadOperations.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = ThreadOperations.cpp; path = PersistentStorageUtilities/ThreadOperationsUtilities/ThreadOperations.cpp; sourceTree = "<group>"; };		CBFE58282885852B003B94C9 /* ThreadOperations.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = ThreadOperations.cpp; path = PersistentStorageUtilities/ThreadOperationsUtilities/ThreadOperations.cpp; sourceTree = "<group>"; };
F53DA7B3F26C2798DCE74A94 /* Pods-Comm.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Comm.debug.xcconfig"; path = "Target Support Files/Pods-Comm/Pods-Comm.debug.xcconfig"; sourceTree = "<group>"; };		F53DA7B3F26C2798DCE74A94 /* Pods-Comm.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Comm.debug.xcconfig"; path = "Target Support Files/Pods-Comm/Pods-Comm.debug.xcconfig"; sourceTree = "<group>"; };
FC2DF95128BFCFE90017C4AF /* tunnelbroker.grpc.pb.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = tunnelbroker.grpc.pb.cc; sourceTree = "<group>"; };		FC2DF95128BFCFE90017C4AF /* tunnelbroker.grpc.pb.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = tunnelbroker.grpc.pb.cc; sourceTree = "<group>"; };
FC2DF95228BFCFE90017C4AF /* tunnelbroker.grpc.pb.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = tunnelbroker.grpc.pb.h; sourceTree = "<group>"; };		FC2DF95228BFCFE90017C4AF /* tunnelbroker.grpc.pb.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = tunnelbroker.grpc.pb.h; sourceTree = "<group>"; };
FC2DF95328BFCFE90017C4AF /* tunnelbroker.pb.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = tunnelbroker.pb.cc; sourceTree = "<group>"; };		FC2DF95328BFCFE90017C4AF /* tunnelbroker.pb.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = tunnelbroker.pb.cc; sourceTree = "<group>"; };
FC2DF95428BFCFE90017C4AF /* tunnelbroker.pb.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = tunnelbroker.pb.h; sourceTree = "<group>"; };		FC2DF95428BFCFE90017C4AF /* tunnelbroker.pb.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = tunnelbroker.pb.h; sourceTree = "<group>"; };
/* End PBXFileReference section */		/* End PBXFileReference section */
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines	718A3C0426F22BD100F04A8D /* grpc */ = {
2DDA00CA889DFF0ECB7E338D /* ClientGetReadReactor.cpp */,		2DDA00CA889DFF0ECB7E338D /* ClientGetReadReactor.cpp */,
);		);
path = grpc;		path = grpc;
sourceTree = "<group>";		sourceTree = "<group>";
};		};
71B8CCB626BD30EC0040C0A2 /* CommCoreImplementations */ = {		71B8CCB626BD30EC0040C0A2 /* CommCoreImplementations */ = {
isa = PBXGroup;		isa = PBXGroup;
children = (		children = (
		CBF332CF28E3037000E80062 /* GlobalDBSingletonIOSProxy.h */,
		CBF332CE28E3037000E80062 /* GlobalDBSingletonIOSProxy.mm */,
CB38B4782877177B00171182 /* TemporaryMessageStorage */,		CB38B4782877177B00171182 /* TemporaryMessageStorage */,
71762A74270D8AAE00F565ED /* PlatformSpecificTools.mm */,		71762A74270D8AAE00F565ED /* PlatformSpecificTools.mm */,
71D4D7CB26C50B1000FCDBCD /* CommSecureStore.mm */,		71D4D7CB26C50B1000FCDBCD /* CommSecureStore.mm */,
71142A7526C2650A0039DCBD /* CommSecureStoreIOSWrapper.h */,		71142A7526C2650A0039DCBD /* CommSecureStoreIOSWrapper.h */,
71142A7626C2650A0039DCBD /* CommSecureStoreIOSWrapper.mm */,		71142A7626C2650A0039DCBD /* CommSecureStoreIOSWrapper.mm */,
71CA4AEA262F230A00835C89 /* Tools.h */,		71CA4AEA262F230A00835C89 /* Tools.h */,
71CA4AEB262F236100835C89 /* Tools.mm */,		71CA4AEB262F236100835C89 /* Tools.mm */,
71CA4A63262DA8E500835C89 /* Logger.mm */,		71CA4A63262DA8E500835C89 /* Logger.mm */,
▲ Show 20 Lines • Show All 689 Lines • ▼ Show 20 Lines	13B07F871A680F5B00A75B9A /* Sources */ = {
718DE99E2653D41C00365824 /* WorkerThread.cpp in Sources */,		718DE99E2653D41C00365824 /* WorkerThread.cpp in Sources */,
8B99BAAE28D511FF00EB5ADB /* lib.rs.cc in Sources */,		8B99BAAE28D511FF00EB5ADB /* lib.rs.cc in Sources */,
71CA4AEC262F236100835C89 /* Tools.mm in Sources */,		71CA4AEC262F236100835C89 /* Tools.mm in Sources */,
71009A7B26FDCD72002C8453 /* Client.cpp in Sources */,		71009A7B26FDCD72002C8453 /* Client.cpp in Sources */,
71762A75270D8AAE00F565ED /* PlatformSpecificTools.mm in Sources */,		71762A75270D8AAE00F565ED /* PlatformSpecificTools.mm in Sources */,
71BF5B7126B3FF0900EDE27D /* Session.cpp in Sources */,		71BF5B7126B3FF0900EDE27D /* Session.cpp in Sources */,
726E5D752731A4790032361D /* NetworkModule.cpp in Sources */,		726E5D752731A4790032361D /* NetworkModule.cpp in Sources */,
71BF5B7526B401D300EDE27D /* Tools.cpp in Sources */,		71BF5B7526B401D300EDE27D /* Tools.cpp in Sources */,
		CBF332D028E3037000E80062 /* GlobalDBSingletonIOSProxy.mm in Sources */,
13B07FBC1A68108700A75B9A /* AppDelegate.mm in Sources */,		13B07FBC1A68108700A75B9A /* AppDelegate.mm in Sources */,
71142A7726C2650B0039DCBD /* CommSecureStoreIOSWrapper.mm in Sources */,		71142A7726C2650B0039DCBD /* CommSecureStoreIOSWrapper.mm in Sources */,
FC2DF95528BFCFE90017C4AF /* tunnelbroker.grpc.pb.cc in Sources */,		FC2DF95528BFCFE90017C4AF /* tunnelbroker.grpc.pb.cc in Sources */,
CB38F2B1286C6C870010535C /* MessageOperationsUtilities.cpp in Sources */,		CB38F2B1286C6C870010535C /* MessageOperationsUtilities.cpp in Sources */,
71BE84492636A944002849D2 /* NativeModules.cpp in Sources */,		71BE84492636A944002849D2 /* NativeModules.cpp in Sources */,
71CA4A64262DA8E500835C89 /* Logger.mm in Sources */,		71CA4A64262DA8E500835C89 /* Logger.mm in Sources */,
71BF5B7F26BBDD7400EDE27D /* CryptoModule.cpp in Sources */,		71BF5B7F26BBDD7400EDE27D /* CryptoModule.cpp in Sources */,
71BE844A2636A944002849D2 /* CommCoreModule.cpp in Sources */,		71BE844A2636A944002849D2 /* CommCoreModule.cpp in Sources */,
▲ Show 20 Lines • Show All 688 Lines • Show Last 20 Lines

[identity] some nitsClosedPublicActions