Page MenuHomePhabricator
Differential D7540

[identity] wallet login
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 1:28 PM.
Tags
None
Referenced Files
F3555608: D7540.id25465.diff
Thu, Dec 26, 11:06 PM
F3555556: D7540.id25421.diff
Thu, Dec 26, 11:03 PM
F3555503: D7540.id25624.diff
Thu, Dec 26, 10:51 PM
F3555436: D7540.id25638.diff
Thu, Dec 26, 10:22 PM
F3542553: D7540.diff
Thu, Dec 26, 8:29 AM
Unknown Object (File)
Wed, Dec 25, 12:37 PM
Unknown Object (File)
Sat, Dec 21, 12:00 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
• jon
bartek
ashoat
Commits
rCOMM169c727790e9: [identity] wallet login
Summary

this RPC is called by both new and existing users signing in with an ethereum wallet. as a result, we need to use the wallet address to check if the user exists before determining whether to update a given user in DDB or create a new entry. we return an access token on successful login.

used the siwe-rs crate to verify the SIWE signature.

Depends on D7539

Test Plan

called the RPC, got back an access token, saw that a new item was created in DDB. then tried logging in again with the same wallet and the existing item in DDB users table was updated.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 19 2023, 1:28 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptApr 19 2023, 1:28 PM
varun added a child revision: D7541: [identity] move device_info creation to helper function.Apr 19 2023, 1:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:40 PM
Harbormaster failed remote builds in B18540: Diff 25404!
varun updated this revision to Diff 25421.Apr 19 2023, 2:20 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:36 PM
Harbormaster failed remote builds in B18556: Diff 25421!
varun updated this revision to Diff 25465.Apr 20 2023, 10:14 AM

rebase

Harbormaster completed remote builds in B18589: Diff 25465.Apr 20 2023, 10:37 AM
varun requested review of this revision.Apr 20 2023, 10:37 AM
ashoat resigned from this revision.Apr 21 2023, 6:01 AM

proto comment change looks fine; no context on the Rust

• jon requested changes to this revision.Apr 24 2023, 1:24 PM
• jon added inline comments.
services/identity/src/siwe.rs
18–41 ↗(On Diff #25465)

Feels weird to have a mix of match and map_err. Generally I prefer map_err. It keeps the cyclomatic complexity down. And with only a 80 char limit, it usually makes it a bit more readable as you aren't losing a lot of indention space.

This revision now requires changes to proceed.Apr 24 2023, 1:24 PM
varun updated this revision to Diff 25624.Apr 24 2023, 1:46 PM

address feedback

Harbormaster completed remote builds in B18711: Diff 25624.Apr 24 2023, 2:04 PM
• jon accepted this revision.Apr 24 2023, 3:25 PM
• jon added inline comments.
services/identity/src/siwe.rs
10–16 ↗(On Diff #25624)

also uses match

This revision is now accepted and ready to land.Apr 24 2023, 3:25 PM
Closed by commit rCOMM169c727790e9: [identity] wallet login (authored by varun). · Explain WhyApr 24 2023, 8:33 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM169c727790e9: [identity] wallet login.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
125 lines
3 lines
190 lines
1 line
34 lines
shared/
protos/
2 lines

Diff 25638

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

services/identity/src/siwe.rs

Loading...
View Options

shared/protos/identity_client.proto

Loading...