Page MenuHomePhabricator
Differential D7652

[lib] Allow calling message search from client
ClosedPublic
Actions

Authored by inka on Apr 27 2023, 6:23 AM.
Tags
None
Referenced Files
F5337807: D7652.id.diff
Wed, Apr 9, 12:55 AM
F5336390: D7652.diff
Wed, Apr 9, 12:13 AM
F5336296: D7652.id.diff
Wed, Apr 9, 12:10 AM
F5335052: D7652.id26925.diff
Tue, Apr 8, 11:10 PM
F5334698: D7652.id26715.diff
Tue, Apr 8, 10:59 PM
F5334643: D7652.id25820.diff
Tue, Apr 8, 10:58 PM
F5333930: D7652.id26154.diff
Tue, Apr 8, 10:39 PM
F5330074: D7652.id26034.diff
Tue, Apr 8, 9:20 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
bartek
kamil
• kuba
ashoat
Commits
rCOMMed08ed3c47d3: [lib] Allow calling message search from client
Summary

issue: https://linear.app/comm/issue/ENG-3170/create-a-keyserver-endpoint-for-the-message-search-within-specific

Test Plan

called

dispatchActionPromise(
        searchMessagesActionTypes,
        this.props.searchMessages({
          threadID: inputThreadInfo.id,
          query: messageInfo.text,
        }),
      );

from input-state-container, checked with redux tools that start/success actions for message search appear, and that the success action has a correct payload containing the search results.

Diff Detail

Repository
rCOMM Comm
Branch
inka/search_backend
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Apr 27 2023, 6:23 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 27 2023, 6:23 AM
inka added a parent revision: D7651: [keyserver, lib] Add message search endpoint.Apr 27 2023, 6:23 AM
Harbormaster completed remote builds in B18851: Diff 25820.Apr 27 2023, 6:41 AM
inka requested review of this revision.Apr 27 2023, 6:41 AM
ashoat accepted this revision.Apr 27 2023, 12:44 PM
This revision is now accepted and ready to land.Apr 27 2023, 12:44 PM
inka updated this revision to Diff 26034.May 3 2023, 1:04 AM

Rebase

Harbormaster completed remote builds in B19014: Diff 26034.May 3 2023, 1:21 AM
inka updated this revision to Diff 26154.May 8 2023, 2:00 AM

Changes due to changes in previous diffs

Harbormaster completed remote builds in B19104: Diff 26154.May 8 2023, 2:17 AM
inka added a child revision: D7739: [native] Add message search context.May 8 2023, 4:20 AM
bartek accepted this revision.May 9 2023, 2:53 AM
inka updated this revision to Diff 26715.May 20 2023, 12:38 AM

Rebsae

Harbormaster completed remote builds in B19535: Diff 26715.May 20 2023, 12:56 AM
inka updated this revision to Diff 26925.May 24 2023, 1:39 AM

Rebase

Harbormaster completed remote builds in B19712: Diff 26925.May 24 2023, 1:56 AM
Closed by commit rCOMMed08ed3c47d3: [lib] Allow calling message search from client (authored by • InkaSokolowska). · Explain WhyMay 24 2023, 2:12 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMed08ed3c47d3: [lib] Allow calling message search from client.

Revision Contents
Changeset List

PathSize
lib/
actions/
21 lines
types/
17 lines

Diff 26034

View Options

lib/actions/message-actions.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
marcinAuthorUnsubmitted
Done
Inline Actions

It might look uncommon to have interface declaration and implementation next to each other in a single file but in fact we don't need to expose CommServicesAuthMetadataIOSWrapper. If we want to call sendAuthMetadataToJS from Objective - C we can use the common C++ API so let's avoid creating unnecessary files and duplication the same API.

marcin: It might look uncommon to have interface declaration and implementation next to each other in a…
bartekUnsubmitted
Not Done
Inline Actions

It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes sense here

bartek: It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes…
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID;
bartekUnsubmitted
Not Done
Inline Actions

What about sendAccessTokenToJS: ... withUserID: ... withDeviceID?

Initially, I got confused because I understood sendToJSAccessToken as "send something to JS-based access token" 😅

bartek: What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused…
varunUnsubmitted
Not Done
Inline Actions

+1

varun: +1
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
NSDictionary *eventBody = @{
@"accessToken" : accessToken,
@"userID" : userID,
@"deviceID" : deviceID
};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID,
rust::String deviceID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
NSString *deviceIDObjC =
[NSString stringWithCString:std::string(deviceID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendToJSAccessToken:accessTokenObjC
withUserID:userIDObjC
withDeviceID:deviceIDObjC];
}
} // namespace comm
View Options

lib/types/redux-types.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
marcinAuthorUnsubmitted
Done
Inline Actions

It might look uncommon to have interface declaration and implementation next to each other in a single file but in fact we don't need to expose CommServicesAuthMetadataIOSWrapper. If we want to call sendAuthMetadataToJS from Objective - C we can use the common C++ API so let's avoid creating unnecessary files and duplication the same API.

marcin: It might look uncommon to have interface declaration and implementation next to each other in a…
bartekUnsubmitted
Not Done
Inline Actions

It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes sense here

bartek: It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes…
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID;
bartekUnsubmitted
Not Done
Inline Actions

What about sendAccessTokenToJS: ... withUserID: ... withDeviceID?

Initially, I got confused because I understood sendToJSAccessToken as "send something to JS-based access token" 😅

bartek: What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused…
varunUnsubmitted
Not Done
Inline Actions

+1

varun: +1
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
NSDictionary *eventBody = @{
@"accessToken" : accessToken,
@"userID" : userID,
@"deviceID" : deviceID
};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID,
rust::String deviceID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
NSString *deviceIDObjC =
[NSString stringWithCString:std::string(deviceID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendToJSAccessToken:accessTokenObjC
withUserID:userIDObjC
withDeviceID:deviceIDObjC];
}
} // namespace comm