Page MenuHomePhabricator

[web] Add new edit message provider
ClosedPublic

Authored by kuba on May 11 2023, 6:01 AM.
Tags
None
Referenced Files
F1832305: D7794.id26944.diff
Thu, May 23, 11:51 AM
F1832304: D7794.id26577.diff
Thu, May 23, 11:51 AM
F1832302: D7794.id26401.diff
Thu, May 23, 11:51 AM
F1832301: D7794.id.diff
Thu, May 23, 11:51 AM
F1832298: D7794.diff
Thu, May 23, 11:51 AM
Unknown Object (File)
Tue, May 21, 11:20 PM
Unknown Object (File)
Sat, May 18, 5:23 AM
Unknown Object (File)
Fri, May 17, 9:50 PM
Subscribers

Details

Summary

Created a new context for message editing. Used ModalOverlay template.

Test Plan

In later diffs checked if the context works correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

web/chat/edit-message-provider.js
58–63 ↗(On Diff #26401)

Is there a reason why this isn't just in the React.useMemo for the modal?

kuba marked an inline comment as done.

Added useMemo to modalOverlay

web/chat/edit-message-provider.js
58–63 ↗(On Diff #26401)

No, added it.

This revision is now accepted and ready to land.May 19 2023, 2:55 AM