Page MenuHomePhabricator
Differential D8237

[web] Display invite links button conditionally
ClosedPublic
Actions

Authored by tomek on Jun 16 2023, 4:28 AM.
Tags
None
Referenced Files
F2829055: D8237.id28105.diff
Fri, Sep 27, 3:15 PM
F2820023: D8237.id28105.diff
Thu, Sep 26, 5:55 PM
F2820021: D8237.id27831.diff
Thu, Sep 26, 5:55 PM
F2819990: D8237.id.diff
Thu, Sep 26, 5:55 PM
F2819962: D8237.diff
Thu, Sep 26, 5:50 PM
Unknown Object (File)
Sat, Sep 14, 12:56 PM
Unknown Object (File)
Sat, Aug 31, 3:02 PM
Unknown Object (File)
Aug 27 2024, 6:44 PM
View All 56 Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
Commits
rCOMM93563ab25e43: [web] Display invite links button conditionally
Summary

When a community has invite link, we display it next to the community in the drawer. We're using our Menu component in a new variant.

invite-button-web.png (504×826 px, 55 KB)

Depends on D8236

Test Plan

Check if button is displayed only for communities with invite links and if clicking it results in menu being shown.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jun 16 2023, 4:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 16 2023, 4:28 AM
tomek edited the summary of this revision. (Show Details)Jun 16 2023, 4:29 AM
tomek added a child revision: D8238: [web] Create link view modal.Jun 16 2023, 4:31 AM
Harbormaster completed remote builds in B20308: Diff 27831.Jun 16 2023, 4:45 AM
tomek requested review of this revision.Jun 16 2023, 4:45 AM
kamil accepted this revision.Jun 19 2023, 2:59 AM
This revision is now accepted and ready to land.Jun 19 2023, 2:59 AM
tomek added a child revision: D8292: [lib][native] Extract invite link url.Jun 22 2023, 7:20 AM
tomek removed a child revision: D8238: [web] Create link view modal.Jun 22 2023, 7:21 AM
tomek added a child revision: D8238: [web] Create link view modal.Jun 22 2023, 7:24 AM
tomek removed a child revision: D8238: [web] Create link view modal.Jun 22 2023, 7:27 AM
Closed by commit rCOMM93563ab25e43: [web] Display invite links button conditionally (authored by tomek). · Explain WhyJun 26 2023, 6:04 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM93563ab25e43: [web] Display invite links button conditionally.

Revision Contents
Changeset List

PathSize
web/
components/
7 lines
3 lines
invite-links/
3 lines
38 lines
sidebar/
2 lines

Diff 27831

View Options

web/components/menu.css

Loading...
View Options

web/components/menu.react.js

Loading...
View Options

web/invite-links/invite-links-menu.css

Loading...
View Options

web/invite-links/invite-links-menu.react.js

Loading...
View Options

web/sidebar/community-drawer-item-community.react.js

Loading...