Call clipboard copy API just like in other places on web. The discussion about operation feedback is still in progress https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz?node-id=11400:282507#473816740.
Depends on D8238
Details
Details
- Reviewers
bartek kamil inka - Commits
- rCOMMa28409f77f27: [web] Allow copying the link
Click copy button and check if the link is in the clipboard.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- invite-web
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/invite-links/view-invite-link-modal.react.js | ||
|---|---|---|
| 28 | Are there other places where we generate this link? I'm a fan of having a single source of truth for such values somewhere in lib/ to make it easier to change where we e.g. migrate to a new domain. I did sth similar in lib/utils/blob-service.js. What do you think? | |
| web/invite-links/view-invite-link-modal.react.js | ||
|---|---|---|
| 28 | I see it is hardcoded in two places on native. Can we define this somewhere in lib? | |
| web/invite-links/view-invite-link-modal.react.js | ||
|---|---|---|
| 28 | Yep, that makes sense! | |