Paths

Table of Contentst

Differential D8264

[web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 12:02 PM.

Tags

None

Referenced Files

	F3409126: D8264.id28008.diff
	Wed, Dec 4, 3:03 PM

	F3409073: D8264.id27910.diff
	Wed, Dec 4, 2:52 PM

	F3409068: D8264.id28010.diff
	Wed, Dec 4, 2:52 PM

	F3407607: D8264.diff
	Wed, Dec 4, 6:57 AM

	Unknown Object (File)
	Mon, Nov 25, 2:49 PM

	Unknown Object (File)
	Mon, Nov 25, 1:47 PM

	Unknown Object (File)
	Sat, Nov 23, 1:06 PM

	Unknown Object (File)
	Sat, Nov 23, 1:06 PM

Subscribers

Details

Reviewers

ashoat
ginsu
rohan
inka
michal
kamil

Commits

rCOMMec4c44bb5ab1: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`

Summary

Hide the EditUserAvatarMenu when userAvatarSaveInProgress. Matches behavior of native.

Personally don't like when elements disappear/reappear, so would've preferred graying it out/disabling it... but this is fine for now.

Depends on D8263

Test Plan

Works as expected.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 20 2023, 12:02 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 12:02 PM

Harbormaster completed remote builds in B20365: Diff 27910.Jun 20 2023, 12:20 PM

atul requested review of this revision.Jun 20 2023, 12:20 PM

atul added a child revision: D8265: [web] Introduce placeholder `EmojiAvatarSelectionModal`.Jun 20 2023, 12:54 PM

atul added reviewers: rohan, inka, michal, kamil.Jun 21 2023, 9:45 AM

Personally don't like when elements disappear/reappear, so would've preferred graying it out/disabling it..

Yeah, I also think it's better

web/avatars/edit-user-avatar.react.js
33	nit: `null` just feels more natural to me here, `undefined` is more like having something which hasn't been set yet or because of some error can not be set while `null` is intentionally meaning that empty value ~ but I suppose it's also okay the way it is, so leaving this up to you

This revision is now accepted and ready to land.Jun 22 2023, 5:02 AM

undefined -> null

web/avatars/edit-user-avatar.react.js
33	Yeah you're totally right, should have been `null`

This revision was landed with ongoing or failed builds.Jun 22 2023, 10:56 AM

Closed by commit rCOMMec4c44bb5ab1: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMec4c44bb5ab1: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`.

Harbormaster failed remote builds in B20434: Diff 28008!Jun 22 2023, 11:17 AM

Revision Contents
Changeset List

Path

Size

web/

avatars/

edit-user-avatar.react.js

2 lines

Diff 27910

web/avatars/edit-user-avatar.react.js

Loading...