Page MenuHomePhabricator
Differential D8265

[web] Introduce placeholder `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 12:54 PM.
Tags
None
Referenced Files
F3532970: D8265.id27911.diff
Wed, Dec 25, 10:40 AM
F3532966: D8265.id28022.diff
Wed, Dec 25, 10:36 AM
F3531888: D8265.id28025.diff
Wed, Dec 25, 8:14 AM
Unknown Object (File)
Thu, Dec 19, 1:44 PM
Unknown Object (File)
Sat, Dec 14, 7:16 AM
Unknown Object (File)
Sat, Dec 7, 3:23 AM
Unknown Object (File)
Fri, Dec 6, 9:50 PM
Unknown Object (File)
Fri, Nov 29, 7:52 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
kamil
michal
inka
rohan
Commits
rCOMMcf20a2d29ebf: [web] Introduce placeholder `EmojiAvatarSelectionModal`
Summary

Introduce placeholder EmojiAvatarSelectionModal component. Modal opens when "Select emoji" MenuItem in EditUserAvatarMenu is clicked.

Layout/styling/functionality will be introduced incrementally in subsequent diffs.

Depends on D8264

Test Plan

Opens and looks about as expected:

03509c.png (256×1 px, 20 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 20 2023, 12:54 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 12:54 PM
atul edited the test plan for this revision. (Show Details)Jun 20 2023, 12:54 PM
Harbormaster completed remote builds in B20366: Diff 27911.Jun 20 2023, 1:14 PM
atul requested review of this revision.Jun 20 2023, 1:14 PM
atul added a child revision: D8266: [web] Add `Avatar` preview to `EmojiAvatarSelectionModal`.Jun 20 2023, 1:32 PM
atul added a comment.Jun 20 2023, 2:10 PM

(This really should have been named something like EmojiUserAvatarSelectionModal since it's UserAvatar-specific. Common parts will be factored out when I get to ThreadAvatars, but for now it's pretty user avatar-specific)

atul added reviewers: kamil, michal, inka, rohan.Jun 21 2023, 9:46 AM
rohan accepted this revision.Jun 21 2023, 10:39 AM

Looks good, just left some style preferences inline

web/avatars/edit-user-avatar-menu.react.js
27

Would personally prefer directly destructuring pushModal here

29–31

Could use shorthand here

web/avatars/emoji-avatar-selection-modal.react.js
10

Would personally prefer directly destructuring popModal here

This revision is now accepted and ready to land.Jun 21 2023, 10:39 AM
atul updated this revision to Diff 28022.Jun 22 2023, 2:06 PM

rebase before landing

atul updated this revision to Diff 28025.Jun 22 2023, 2:10 PM

rebase before addressing @rohan's feedback

Harbormaster failed remote builds in B20440: Diff 28022!Jun 22 2023, 2:34 PM
Harbormaster failed remote builds in B20443: Diff 28025!Jun 22 2023, 2:37 PM
atul updated this revision to Diff 28063.Jun 23 2023, 12:57 PM

rebase

Harbormaster completed remote builds in B20480: Diff 28063.Jun 23 2023, 1:14 PM
atul updated this revision to Diff 28071.Jun 23 2023, 1:27 PM

address feedback

Harbormaster completed remote builds in B20485: Diff 28071.Jun 23 2023, 1:46 PM
Closed by commit rCOMMcf20a2d29ebf: [web] Introduce placeholder `EmojiAvatarSelectionModal` (authored by atul). · Explain WhyJun 23 2023, 2:07 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMcf20a2d29ebf: [web] Introduce placeholder `EmojiAvatarSelectionModal`.

Revision Contents
Changeset List

Diff 27911

View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...