Page MenuHomePhabricator
Differential D8246

[web] Refresh invite links
ClosedPublic
Actions

Authored by tomek on Jun 19 2023, 8:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 6:11 PM
Unknown Object (File)
Tue, Apr 22, 9:42 AM
Unknown Object (File)
Tue, Apr 22, 9:17 AM
Unknown Object (File)
Tue, Apr 22, 6:10 AM
Unknown Object (File)
Tue, Apr 22, 3:08 AM
Unknown Object (File)
Mon, Apr 21, 12:00 PM
Unknown Object (File)
Wed, Apr 2, 8:19 AM
Unknown Object (File)
Tue, Apr 1, 10:15 AM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
Commits
rCOMMbd5f5b2f701e: [web] Refresh invite links
Summary

Every time a window becomes active, fetch invite links so that we can display the most recent version without requesting too often. Ultimately, we would like to have a mechanism where every invite link change results in updates being sent to interested clients.

Depends on D8239

Test Plan

Check if actions are dispatched when the window becomes active.
Modify website responder so that an empty invite links store is returned. Check if the links are updated after successful result is returned from the server when a window becomes active.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jun 19 2023, 8:42 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 19 2023, 8:42 AM
Harbormaster completed remote builds in B20323: Diff 27858.Jun 19 2023, 8:59 AM
tomek requested review of this revision.Jun 19 2023, 8:59 AM
kamil accepted this revision.Jun 22 2023, 3:29 AM
kamil added inline comments.
web/invite-links/invite-links-refresher.react.js
22 ↗(On Diff #27858)

shouldn't we also check whether we have logged in user to avoid not necessary endpoint calls?

This revision is now accepted and ready to land.Jun 22 2023, 3:29 AM
tomek added inline comments.Jun 22 2023, 7:28 AM
web/invite-links/invite-links-refresher.react.js
22 ↗(On Diff #27858)

Ok, makes sense!

tomek updated this revision to Diff 28005.Jun 22 2023, 8:11 AM

Fetch links only when user is logged in and clear the store after logout

Harbormaster failed remote builds in B20431: Diff 28005!Jun 22 2023, 8:33 AM
tomek added a child revision: D8294: [web] Update button label after successful copy.Jun 22 2023, 8:55 AM
Harbormaster completed remote builds in B20431: Diff 28005.Jun 26 2023, 4:13 AM
Closed by commit rCOMMbd5f5b2f701e: [web] Refresh invite links (authored by tomek). · Explain WhyJun 26 2023, 6:04 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMbd5f5b2f701e: [web] Refresh invite links.

Revision Contents
Changeset List

PathSize
lib/
reducers/
14 lines
web/
2 lines
invite-links/
36 lines

Diff 28005

View Options

lib/reducers/invite-links-reducer.js

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(this->getRequest); getS3Client()->GetObject(this->getRequest);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
return std::make_unique<grpc::Status>( return std::make_unique<grpc::Status>(
grpc::StatusCode::INTERNAL, getOutcome.GetError().GetMessage()); grpc::StatusCode::INTERNAL, getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
result.resize(nextSize); std::stringstream buffer;
retrievedFile.get((char *)result.data(), nextSize + 1); buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
response->set_datachunk(result); response->set_datachunk(result);
this->offset += nextSize; this->offset += nextSize;
return nullptr; return nullptr;
} }
void initialize() override { void initialize() override {
this->s3Path = findS3Path(this->request.holder()); this->s3Path = findS3Path(this->request.holder());
Show All 23 Lines
View Options

web/app.react.js

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(this->getRequest); getS3Client()->GetObject(this->getRequest);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
return std::make_unique<grpc::Status>( return std::make_unique<grpc::Status>(
grpc::StatusCode::INTERNAL, getOutcome.GetError().GetMessage()); grpc::StatusCode::INTERNAL, getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
result.resize(nextSize); std::stringstream buffer;
retrievedFile.get((char *)result.data(), nextSize + 1); buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
response->set_datachunk(result); response->set_datachunk(result);
this->offset += nextSize; this->offset += nextSize;
return nullptr; return nullptr;
} }
void initialize() override { void initialize() override {
this->s3Path = findS3Path(this->request.holder()); this->s3Path = findS3Path(this->request.holder());
Show All 23 Lines
View Options

web/invite-links/invite-links-refresher.react.js

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(this->getRequest); getS3Client()->GetObject(this->getRequest);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
return std::make_unique<grpc::Status>( return std::make_unique<grpc::Status>(
grpc::StatusCode::INTERNAL, getOutcome.GetError().GetMessage()); grpc::StatusCode::INTERNAL, getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
result.resize(nextSize); std::stringstream buffer;
retrievedFile.get((char *)result.data(), nextSize + 1); buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
response->set_datachunk(result); response->set_datachunk(result);
this->offset += nextSize; this->offset += nextSize;
return nullptr; return nullptr;
} }
void initialize() override { void initialize() override {
this->s3Path = findS3Path(this->request.holder()); this->s3Path = findS3Path(this->request.holder());
Show All 23 Lines