Details

Reviewers

ashoat
ginsu
kamil
michal
inka
rohan

Commits

rCOMMcf20a2d29ebf: [web] Introduce placeholder `EmojiAvatarSelectionModal`

Summary

Introduce placeholder EmojiAvatarSelectionModal component. Modal opens when "Select emoji" MenuItem in EditUserAvatarMenu is clicked.

Layout/styling/functionality will be introduced incrementally in subsequent diffs.

Depends on D8264

Test Plan

Opens and looks about as expected:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 20 2023, 12:54 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 12:54 PM

atul edited the test plan for this revision. (Show Details)Jun 20 2023, 12:54 PM

Harbormaster completed remote builds in B20366: Diff 27911.Jun 20 2023, 1:14 PM

atul requested review of this revision.Jun 20 2023, 1:14 PM

atul added a child revision: D8266: [web] Add `Avatar` preview to `EmojiAvatarSelectionModal`.Jun 20 2023, 1:32 PM

(This really should have been named something like EmojiUserAvatarSelectionModal since it's UserAvatar-specific. Common parts will be factored out when I get to ThreadAvatars, but for now it's pretty user avatar-specific)

atul added reviewers: kamil, michal, inka, rohan.Jun 21 2023, 9:46 AM

Looks good, just left some style preferences inline

web/avatars/edit-user-avatar-menu.react.js
27 ↗	(On Diff #27911)	Would personally prefer directly destructuring `pushModal` here
29–31 ↗	(On Diff #27911)	Could use shorthand here
web/avatars/emoji-avatar-selection-modal.react.js
10 ↗	(On Diff #27911)	Would personally prefer directly destructuring `popModal` here