Tags

None

Referenced Files

	F2838098: D8438.id28472.diff
	Sat, Sep 28, 8:39 PM

	F2838060: D8438.id28900.diff
	Sat, Sep 28, 8:36 PM

	F2837317: D8438.diff
	Sat, Sep 28, 6:24 PM

	F2831655: D8438.id28904.diff
	Sat, Sep 28, 12:55 AM

	F2831654: D8438.id28900.diff
	Sat, Sep 28, 12:55 AM

	F2831653: D8438.id28472.diff
	Sat, Sep 28, 12:55 AM

	F2831628: D8438.id.diff
	Sat, Sep 28, 12:55 AM

	F2831615: D8438.diff
	Sat, Sep 28, 12:49 AM

View All 99 Files

Subscribers

ashoat

tomek

Details

Reviewers

michal
• patryk
• jon
varun

Commits

rCOMM4933f329fa0d: [services-lib] Add integer and timestamp parsing helpers

Summary

Adds a helper function to parse UTC timestamp DynamoDB attribute values.
Also improved the existing number parsing function to be more flexible
and renamed it to parse_integer because it was created specifically for integers

Test Plan

Unit tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 7 2023, 5:44 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 7 2023, 5:44 AM

Harbormaster completed remote builds in B20792: Diff 28472.Jul 7 2023, 6:01 AM

bartek added a child revision: D8443: [blob-service] Implement db type conversions.Jul 7 2023, 6:06 AM

bartek published this revision for review.Jul 7 2023, 7:02 AM

varun accepted this revision.Jul 9 2023, 8:19 AM

This revision is now accepted and ready to land.Jul 9 2023, 8:20 AM

michal accepted this revision.Jul 10 2023, 4:29 AM

michal added inline comments.

services/comm-services-lib/src/database.rs
204	Nit: remove line

Rebase

Harbormaster completed remote builds in B21093: Diff 28900.Jul 21 2023, 12:17 AM

Closed by commit rCOMM4933f329fa0d: [services-lib] Add integer and timestamp parsing helpers (authored by bartek). · Explain WhyJul 21 2023, 12:33 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4933f329fa0d: [services-lib] Add integer and timestamp parsing helpers.

[services-lib] Add integer and timestamp parsing helpers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28472

services/comm-services-lib/src/database.rs

services/feature-flags/src/database.rs

[services-lib] Add integer and timestamp parsing helpersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28472

services/comm-services-lib/src/database.rs

services/feature-flags/src/database.rs

[services-lib] Add integer and timestamp parsing helpers
ClosedPublic
Actions

Revision Contents
Changeset List