Page MenuHomePhabricator
Differential D8487

[native] replace `folly::Optional` with `std::optional`
ClosedPublic
Actions

Authored by kamil on Jul 12 2023, 6:15 AM.
Tags
None
Referenced Files
F2176319: D8487.diff
Wed, Jul 3, 3:49 AM
Unknown Object (File)
Mon, Jul 1, 2:11 AM
Unknown Object (File)
Mon, Jul 1, 2:11 AM
Unknown Object (File)
Mon, Jul 1, 2:11 AM
Unknown Object (File)
Mon, Jul 1, 2:08 AM
Unknown Object (File)
Thu, Jun 27, 4:38 PM
Unknown Object (File)
Tue, Jun 25, 3:44 AM
Unknown Object (File)
Tue, Jun 25, 2:15 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
• jon
atul
marcin
Commits
rCOMMa3388afb3ec8: [native] replace `folly::Optional` with `std::optional`
Summary

The point is to avoid adding folly dependency on web.

Emscripten C++17 compatibility will be handled in subsequent diff.

Depends on D8472

Test Plan
  1. Log out
  2. Call getOlmPersistAccountData() -> should return nullopt`
  3. Log in
  4. Call getOlmPersistAccountData()` -> should return string
  5. Tested on both iOS and Android.

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 12 2023, 6:15 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 12 2023, 6:15 AM
kamil added a child revision: D8488: [nix] Enable C++17 support for Emscripten.Jul 12 2023, 6:18 AM
Harbormaster completed remote builds in B20902: Diff 28633.Jul 12 2023, 6:32 AM
kamil published this revision for review.Jul 12 2023, 7:36 AM
michal added inline comments.Jul 14 2023, 2:21 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
944–946 ↗(On Diff #28633)

I think this didn't need to be changed (std::optional also has ->), but I haven't used it personally, so maybe there is some difference, and it doesn't really matter anyway.

michal accepted this revision.Jul 14 2023, 2:21 AM
This revision is now accepted and ready to land.Jul 14 2023, 2:21 AM
kamil added a reviewer: marcin.Jul 17 2023, 2:25 AM
This revision now requires review to proceed.Jul 17 2023, 2:25 AM
tomek accepted this revision.Jul 17 2023, 4:43 AM
marcin accepted this revision.Jul 18 2023, 1:43 AM
This revision is now accepted and ready to land.Jul 18 2023, 1:43 AM
kamil removed a parent revision: D8472: [native] add entity and methods for redux-persist storage.Jul 19 2023, 6:46 AM
kamil updated this revision to Diff 28886.Jul 20 2023, 6:32 AM
kamil added a parent revision: D8472: [native] add entity and methods for redux-persist storage.

use -> operator

kamil removed a parent revision: D8472: [native] add entity and methods for redux-persist storage.Jul 20 2023, 6:33 AM
Harbormaster completed remote builds in B21084: Diff 28886.Jul 20 2023, 6:50 AM
Closed by commit rCOMMa3388afb3ec8: [native] replace `folly::Optional` with `std::optional` (authored by kamil). · Explain WhyJul 20 2023, 6:56 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa3388afb3ec8: [native] replace `folly::Optional` with `std::optional`.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
2 lines
6 lines
NativeModules/
4 lines

Diff 28886

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...