Page MenuHomePhabricator

[native] replace `folly::Optional` with `std::optional`
ClosedPublic

Authored by kamil on Jul 12 2023, 6:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 12:16 AM
Unknown Object (File)
Sat, Oct 26, 1:59 AM
Unknown Object (File)
Mon, Oct 14, 8:52 PM
Unknown Object (File)
Sun, Oct 13, 5:11 AM
Unknown Object (File)
Fri, Oct 11, 8:42 PM
Unknown Object (File)
Sep 28 2024, 2:20 AM
Unknown Object (File)
Sep 28 2024, 2:20 AM
Unknown Object (File)
Sep 28 2024, 2:20 AM
Subscribers

Details

Summary

The point is to avoid adding folly dependency on web.

Emscripten C++17 compatibility will be handled in subsequent diff.

Depends on D8472

Test Plan
  1. Log out
  2. Call getOlmPersistAccountData() -> should return nullopt`
  3. Log in
  4. Call getOlmPersistAccountData()` -> should return string
  5. Tested on both iOS and Android.

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 12 2023, 7:36 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
944–946 ↗(On Diff #28633)

I think this didn't need to be changed (std::optional also has ->), but I haven't used it personally, so maybe there is some difference, and it doesn't really matter anyway.

This revision is now accepted and ready to land.Jul 14 2023, 2:21 AM
This revision now requires review to proceed.Jul 17 2023, 2:25 AM
This revision is now accepted and ready to land.Jul 18 2023, 1:43 AM