Page MenuHomePhabricator
Differential D8457

[blob-service] Support new abstraction in HTTP
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 2:08 PM
Unknown Object (File)
Fri, Nov 1, 6:06 PM
Unknown Object (File)
Fri, Nov 1, 6:05 PM
Unknown Object (File)
Fri, Nov 1, 6:05 PM
Unknown Object (File)
Fri, Nov 1, 6:05 PM
Unknown Object (File)
Fri, Nov 1, 5:44 PM
Unknown Object (File)
Sun, Oct 27, 4:35 PM
Unknown Object (File)
Sep 28 2024, 12:56 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• patryk
• jon
Commits
rCOMMca569b84d930: [blob-service] Support new abstraction in HTTP
Summary

Part of ENG-4269.

Propagated new blob service abstraction to HTTP code. Implemented error handling. Now all kinds of error responses can be handled in one place.

Depends on D8456.

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jul 9 2023, 2:06 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:07 PM
bartek added a child revision: D8458: [blob-service] Call service methods from handlers.Jul 9 2023, 2:07 PM
Harbormaster completed remote builds in B20826: Diff 28513.Jul 9 2023, 2:53 PM
bartek edited the summary of this revision. (Show Details)Jul 9 2023, 11:52 PM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:45 AM
• jon resigned from this revision.Jul 10 2023, 6:18 PM

rust LGTM, would like for someone else to take a look

michal accepted this revision.Jul 17 2023, 3:36 AM
michal added inline comments.
services/blob/src/http/context.rs
78 ↗(On Diff #28513)

Can this also happen if a holder already exists? Should the error be changed?

This revision is now accepted and ready to land.Jul 17 2023, 3:36 AM
bartek updated this revision to Diff 28916.Jul 21 2023, 1:53 AM

Rebase

Harbormaster completed remote builds in B21105: Diff 28916.Jul 21 2023, 3:00 AM
Closed by commit rCOMMca569b84d930: [blob-service] Support new abstraction in HTTP (authored by bartek). · Explain WhyJul 25 2023, 1:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMca569b84d930: [blob-service] Support new abstraction in HTTP.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
71 lines
4 lines
14 lines

Diff 28916

View Options

services/blob/src/http/context.rs

Loading...
View Options

services/blob/src/http/mod.rs

Loading...
View Options

services/blob/src/main.rs

Loading...