Page MenuHomePhabricator
Differential D8456

[blob-service] Implement holder management with new db
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 2:55 PM
Unknown Object (File)
Sat, Nov 23, 12:49 PM
Unknown Object (File)
Sat, Nov 23, 2:15 AM
Unknown Object (File)
Fri, Nov 22, 3:42 PM
Unknown Object (File)
Fri, Nov 22, 3:31 PM
Unknown Object (File)
Fri, Nov 22, 3:06 PM
Unknown Object (File)
Fri, Nov 22, 9:58 AM
Unknown Object (File)
Mon, Nov 18, 2:08 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• patryk
• jon
Commits
rCOMM6bee680ae009: [blob-service] Implement holder management with new db
Summary

Part of ENG-4269.

Mostly copied logic from http::handlers::blob::assign_holder_handler and http::handlers::blob::remove_holder_handler - but now with using the new database methods

Partially addresses the TODO from http::handlers::blob::remove_holder_handler - auto deletion of orphaned blobs can now be disabled

Depends on D8455.

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jul 9 2023, 2:06 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:06 PM
bartek added a child revision: D8457: [blob-service] Support new abstraction in HTTP.Jul 9 2023, 2:06 PM
Harbormaster completed remote builds in B20825: Diff 28512.Jul 9 2023, 2:47 PM
bartek edited the summary of this revision. (Show Details)Jul 9 2023, 11:48 PM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:44 AM
• jon resigned from this revision.Jul 10 2023, 6:18 PM

rust LGTM, would like for someone else to take a look

michal accepted this revision.Jul 17 2023, 3:30 AM
This revision is now accepted and ready to land.Jul 17 2023, 3:30 AM
bartek updated this revision to Diff 28915.Jul 21 2023, 1:53 AM

Rebase

Harbormaster completed remote builds in B21104: Diff 28915.Jul 21 2023, 2:54 AM
Closed by commit rCOMM6bee680ae009: [blob-service] Implement holder management with new db (authored by bartek). · Explain WhyJul 25 2023, 1:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM6bee680ae009: [blob-service] Implement holder management with new db.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
55 lines

Diff 28995

View Options

services/blob/src/service.rs

Loading...