Page MenuHomePhabricator
Differential D8628

[lib/native] update heightMeasurerKey function to consider inline engagement for robotext messages
ClosedPublic
Actions

Authored by ginsu on Jul 25 2023, 12:23 PM.
Tags
None
Referenced Files
F3397711: D8628.id29361.diff
Sun, Dec 1, 7:07 PM
F3397355: D8628.id29032.diff
Sun, Dec 1, 5:19 PM
F3397348: D8628.id29346.diff
Sun, Dec 1, 5:18 PM
Unknown Object (File)
Sat, Nov 23, 6:56 PM
Unknown Object (File)
Sat, Nov 23, 4:23 PM
Unknown Object (File)
Sat, Nov 23, 4:23 PM
Unknown Object (File)
Sat, Nov 2, 3:32 PM
Unknown Object (File)
Oct 28 2024, 5:36 AM
View All 89 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
ashoat
tomek
atul
Commits
rCOMMf29bf4eed7b4: [lib/native] update heightMeasurerKey function to consider inline engagement…
Summary

This next diff updates the heightMeasurerKey function so that we remeasure a message whenever there is a change with the inline engagement for that message. In this diff we want to also consider changes to sidebar text and the reactions since these can all potentially affect the height of the inline engagement node

Depends on D8610

Test Plan

I tested modifying the height of the inline engagement for robotext messages, and when I did this, I no longer got the incorrect height measurement logs from the console

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 25 2023, 12:23 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2023, 12:23 PM
ginsu edited the summary of this revision. (Show Details)Jul 25 2023, 12:26 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil, ashoat, tomek.
ginsu added a parent revision: D8610: [native] introduce DummyInlineEngagementNode.
ginsu attached a referenced file: F653816: Screen Recording 2023-07-25 at 3.13.59 PM.mov. (Show Details)
ginsu attached a referenced file: F653815: Screen Recording 2023-07-25 at 3.10.37 PM.mov. (Show Details)

added @ashoat and @tomek as reviewers since they have the most context on height measurement

Harbormaster completed remote builds in B21196: Diff 29032.Jul 25 2023, 12:39 PM
ginsu requested review of this revision.Jul 25 2023, 12:39 PM
ginsu added a child revision: D8629: [lib/native/web] update getMessageLabel parameters.Jul 25 2023, 1:05 PM
atul resigned from this revision.Jul 25 2023, 11:32 PM
tomek accepted this revision.Jul 26 2023, 3:14 AM
tomek added inline comments.
lib/shared/inline-engagement-utils.js
17–18

We probably don't have good guarantees about iteration order, but it should be fine as we're caring here only about changes in the object.

This revision is now accepted and ready to land.Jul 26 2023, 3:14 AM
ginsu updated this revision to Diff 29346.Jul 31 2023, 12:30 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM
Closed by commit rCOMMf29bf4eed7b4: [lib/native] update heightMeasurerKey function to consider inline engagement… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf29bf4eed7b4: [lib/native] update heightMeasurerKey function to consider inline engagement….
Harbormaster completed remote builds in B21434: Diff 29346.Jul 31 2023, 10:35 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
14 lines
native/
chat/
9 lines

Diff 29032

View Options

lib/shared/inline-engagement-utils.js

Loading...
View Options

native/chat/chat-item-height-measurer.react.js

Loading...