Paths

Table of Contentst

Differential D8811

[web] Add a temporary login via QR code button on the log-in form
ClosedPublic
Actions

Authored by rohan on Aug 14 2023, 11:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 11, 2:07 PM

	Unknown Object (File)
	Mon, Nov 11, 4:58 AM

	Unknown Object (File)
	Thu, Nov 7, 5:07 AM

	Unknown Object (File)
	Mon, Nov 4, 2:26 PM

	Unknown Object (File)
	Mon, Oct 28, 6:16 PM

	Unknown Object (File)
	Sun, Oct 27, 9:00 AM

	Unknown Object (File)
	Oct 11 2024, 2:21 PM

	Unknown Object (File)
	Sep 27 2024, 1:58 PM

Subscribers

Details

Reviewers

atul
ginsu
tomek
varun

Commits

rCOMM7f2251d085b3: [web] Add a temporary login via QR code button on the log-in form

Summary

While the QR code work is still in progress, we want to display a login via QR code button hidden by an if (isDev) check to ensure it's not shown in production (also because ultimately the screen's location will be moved to the main login method, but while it's impossible to login via QR at the moment, this is the next best way to access the flow).

Addresses ENG-4584

Confirmed with Ted regarding the designs of this button in the design channel on Comm

Depends on D8806

Test Plan

Confirmed that the button shows in development

Screenshot 2023-08-14 at 2.49.30 PM.png (1×900 px, 74 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Aug 14 2023, 11:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 14 2023, 11:22 AM

rohan edited the summary of this revision. (Show Details)Aug 14 2023, 11:22 AM

rohan edited the test plan for this revision. (Show Details)

rohan edited the test plan for this revision. (Show Details)

rohan edited the summary of this revision. (Show Details)

Update onClick

Harbormaster completed remote builds in B21735: Diff 29869.Aug 14 2023, 11:40 AM

Harbormaster completed remote builds in B21736: Diff 29870.Aug 14 2023, 11:43 AM

rohan requested review of this revision.Aug 14 2023, 11:43 AM

Change 'login' to 'sign in'

rohan edited the test plan for this revision. (Show Details)Aug 14 2023, 11:50 AM

Harbormaster completed remote builds in B21737: Diff 29871.Aug 14 2023, 12:09 PM

rohan added a child revision: D8818: [lib/web] Route to a barebones QR code login page.Aug 15 2023, 10:11 AM

Nit

web/account/log-in-form.react.js
106 ↗	(On Diff #29871)	Should start with lowercase

Lowercase qRCodeLoginButton

Can we go with qrCodeLoginButton like in my suggestion?

Rename to qrCodeLoginButton (I should've caught this)

Harbormaster completed remote builds in B21769: Diff 29922.Aug 15 2023, 12:27 PM

Harbormaster completed remote builds in B21771: Diff 29924.Aug 15 2023, 12:45 PM

tomek accepted this revision.Aug 16 2023, 3:02 AM

This revision is now accepted and ready to land.Aug 16 2023, 3:02 AM

Closed by commit rCOMM7f2251d085b3: [web] Add a temporary login via QR code button on the log-in form (authored by rohan). · Explain WhyAug 17 2023, 12:50 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM7f2251d085b3: [web] Add a temporary login via QR code button on the log-in form.

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.css

6 lines

log-in-form.react.js

24 lines

Diff 29870

web/account/log-in-form.css

Loading...

web/account/log-in-form.react.js

Loading...