[native] Add a temporary sign in via QR code button on native
ClosedPublic
Actions

Authored by rohan on Aug 18 2023, 11:23 AM.

Details

Reviewers

atul
ginsu
tomek
varun

Commits

rCOMM76fbf968845d: [native] Add a temporary sign in via QR code button on native

Summary

While we're still using the traditional form to log in on native, I'm hiding the QR code login flow behind a new login button (similar to what's done with the register (new) button). This is only
shown in development. The next diff will implement the screen that appears when clicking it.

I followed an approach similar to D7495

Addresses ENG-4649

Depends on D8836

Test Plan

Confirmed that the button appears only in development (only touched the sign in buttons, left register buttons as-is)

`__DEV__`	`!__DEV__`

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Aug 18 2023, 11:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 18 2023, 11:23 AM

rohan edited the test plan for this revision. (Show Details)Aug 18 2023, 11:24 AM

rohan edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B21903: Diff 30089.Aug 18 2023, 11:42 AM

rohan requested review of this revision.Aug 18 2023, 11:42 AM

Confused how the second screenshot shows a Register (new) but NOT a Sign in (QR). Based on the code, shouldn't they show up in the exact same scenarios?

In D8870#261599, @ashoat wrote:

Confused how the second screenshot shows a Register (new) but NOT a Sign in (QR). Based on the code, shouldn't they show up in the exact same scenarios?

I probably could've clarified better. When I said "Confirmed that the button appears only in development (only touched the sign in buttons, left register buttons as-is)", I meant I only toggled the __DEV__ check for the sign-in buttons conditional, and left the register buttons conditional as-is.

Here's what toggling both if (__DEV__) checks to if (!__DEV__) looks like: